Closed
Bug 880813
Opened 12 years ago
Closed 12 years ago
[MMS] Specify maximum allowed file size when invoking the "pick" MozActivity
Categories
(Firefox OS Graveyard :: Gaia::SMS, defect)
Tracking
(blocking-b2g:leo+, b2g18 verified, b2g-v1.1hd fixed)
RESOLVED
FIXED
| blocking-b2g | leo+ |
People
(Reporter: jugglinmike, Assigned: jugglinmike)
References
Details
Attachments
(2 files)
|
6.11 KB,
patch
|
gnarf
:
review+
|
Details | Diff | Splinter Review |
|
59.04 KB,
image/png
|
Details |
2013-08-07-16-45-13.png
As discussed in bug 868225, the MMS application should specify the maximum file size it may accept when initiating a "pick" Activity. This gives the application handling the Activity an opportunity to filter out files that are too large.
|
Assignee | |
Comment 1•12 years ago
|
||
Because this attribute is informal (in other words, Gecko does not honor it in any way), there is no guaruntee that files returning from the "pick" Activity will actually be small enough for inclusion in an MMS message. Therefor, the MMS application should defensively check the size of files returned by the "pick" Activity and display an error if the file is too large.
|
|
Assignee | |
Comment 2•12 years ago
|
||
Attachment #759939 -
Flags: review?(gnarf37)
|
||
Comment 3•12 years ago
|
||
Comment on attachment 759939 [details] [diff] [review]
Specify maximum allowed file size when invoking the "pick" MozActivity
Review of attachment 759939 [details] [diff] [review]:
-----------------------------------------------------------------
r=me
Attachment #759939 -
Flags: review?(gnarf37) → review+
|
|
||
Comment 4•12 years ago
|
||
Dietrich, this is a new bug necessary for the video capture limit stuff we've been talking about.
blocking-b2g: --- → leo?
Flags: needinfo?(dietrich)
|
|
Assignee | |
Comment 5•12 years ago
|
||
Landed with commit 94b58b96098d0459e7ceb66e4a009debc55a0c45
Thanks for the review, Corey!
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
blocking-b2g: leo? → leo+
Flags: needinfo?(dietrich)
|
|
||
Comment 6•12 years ago
|
||
Uplifted 94b58b96098d0459e7ceb66e4a009debc55a0c45 to:
v1-train: b903bc3abbd1bad9eb4761b682d2a0a0d059083b
status-b2g18:
--- → fixed
|
|
||
Comment 7•12 years ago
|
||
1.1hd: b903bc3abbd1bad9eb4761b682d2a0a0d059083b
status-b2g-v1.1hd:
--- → fixed
|
|
||
Comment 8•12 years ago
|
||
When the user reaches is able to see that the user has exceeded the maximum length in an MMS. See screenshot attached.
The issue seemed to be fixed for v1.1
Environmental Variables
Leo Build ID: 20130807071207
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/11bb1b0eefff
Gaia: 60ca81600a080dae33058b0692ecaa213556c926
Platform Version: 18.1
|
|
||
Comment 9•12 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•