880847 - Update libpng's apng.patch to version 1.5.16

Status: VERIFIED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Glenn Randers-Pehrson]

While patching bug#873001 I neglected to update libpng's apng.patch.  While generating this patch I discovered several (insignificant for mozilla) hunks that didn't get updated.  Also the MOZPNG value in configure.in needs to be updated.

Comment 1

[Glenn Randers-Pehrson]

Attachment: v00 Update libpng apng.patch to version 1.5.16

Need tryserver run

Comment 2

[Glenn Randers-Pehrson]

Should apng-patch be moved into a "tools" subdirectory?

Comment 3

[Ryan VanderMeulen [:RyanVM]]

*shrug*

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Sorry, I forgot about this :(

https://tbpl.mozilla.org/?tree=Try&rev=35084fec17a2

Comment 5

[Glenn Randers-Pehrson]

Comment on attachment 759950 [details] [diff] [review]
v00 Update libpng apng.patch to version 1.5.16

If I understand the tryserver report, it passed.  There are a lot of red reftest "is burning" reports, each followed by an apparent rerun that is green.

Comment 6

[Glenn Randers-Pehrson]

Attachment: v02-update-libpng-to-version-1.5.16

Removed a change in png.h that's only needed in the bundled libpng but not when patching a system libpng.  This change won't be seen by the tryserver.

Comment 7

[Glenn Randers-Pehrson]

Comment on attachment 766223 [details] [diff] [review]
v02-update-libpng-to-version-1.5.16

There seems to be little value in maintaining a separate apng patch here that is different from the one at Sourceforge "libpng-apng" project.  That one is more complete because it also patches pngtest.c and scripts/symbol.def which we don't use here.  Other than that, and some insignificant differences in where the APNG code is inserted, they appear to me to be equivalent.  The SourceForge patch was forked from here a while back anyhow, and I'd prefer to merge them again and include a copy here.

Comment 8

[Glenn Randers-Pehrson]

Attachment: v03-update-libpng-to-version-1.5.16

Replaced apng.patch with the one from SourceForge/libpng-apng project.  Ryan, please do a tryserver run (the change should not have any effect on that, but we might as well be sure).

Comment 9

[Glenn Randers-Pehrson]

I was a little bit confused by the fact that there are actually *two* apng-patch projects at Sourceforge, one called "libpng-apng" and the other "apng".  I had intended to use the one from the "apng" project (maintained by Max Stepin), but used the other one in the v03 patch.  As far as I can tell they are equivalent, both being forks of mozilla's.  We can switch to the "apng" project patch for libpng-1.5.17 and libpng-1.6.3.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/023ddaa3993d

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/023ddaa3993d