Closed Bug 880847 Opened 6 years ago Closed 6 years ago

Update libpng's apng.patch to version 1.5.16

Categories

(Core :: ImageLib, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
mozilla25

People

(Reporter: glennrp+bmo, Assigned: glennrp+bmo)

References

Details

Attachments

(1 file, 2 obsolete files)

While patching bug#873001 I neglected to update libpng's apng.patch.  While generating this patch I discovered several (insignificant for mozilla) hunks that didn't get updated.  Also the MOZPNG value in configure.in needs to be updated.
Need tryserver run
Flags: needinfo?(ryanvm)
Should apng-patch be moved into a "tools" subdirectory?
*shrug*
Sorry, I forgot about this :(

https://tbpl.mozilla.org/?tree=Try&rev=35084fec17a2
Flags: needinfo?(ryanvm)
Comment on attachment 759950 [details] [diff] [review]
v00 Update libpng apng.patch to version 1.5.16

If I understand the tryserver report, it passed.  There are a lot of red reftest "is burning" reports, each followed by an apparent rerun that is green.
Attachment #759950 - Flags: review?(joe)
Removed a change in png.h that's only needed in the bundled libpng but not when patching a system libpng.  This change won't be seen by the tryserver.
Attachment #759950 - Attachment is obsolete: true
Attachment #759950 - Flags: review?(joe)
Attachment #766223 - Flags: review?(joe)
Comment on attachment 766223 [details] [diff] [review]
v02-update-libpng-to-version-1.5.16

There seems to be little value in maintaining a separate apng patch here that is different from the one at Sourceforge "libpng-apng" project.  That one is more complete because it also patches pngtest.c and scripts/symbol.def which we don't use here.  Other than that, and some insignificant differences in where the APNG code is inserted, they appear to me to be equivalent.  The SourceForge patch was forked from here a while back anyhow, and I'd prefer to merge them again and include a copy here.
Attachment #766223 - Flags: review?(joe)
Replaced apng.patch with the one from SourceForge/libpng-apng project.  Ryan, please do a tryserver run (the change should not have any effect on that, but we might as well be sure).
Attachment #766223 - Attachment is obsolete: true
Attachment #766474 - Flags: review?(joe)
Flags: needinfo?(ryanvm)
I was a little bit confused by the fact that there are actually *two* apng-patch projects at Sourceforge, one called "libpng-apng" and the other "apng".  I had intended to use the one from the "apng" project (maintained by Max Stepin), but used the other one in the v03 patch.  As far as I can tell they are equivalent, both being forks of mozilla's.  We can switch to the "apng" project patch for libpng-1.5.17 and libpng-1.6.3.
Attachment #766474 - Flags: review?(joe) → review+
Blocks: 886499
Keywords: checkin-needed
Flags: needinfo?(ryanvm)
https://hg.mozilla.org/mozilla-central/rev/023ddaa3993d
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.