Closed Bug 880853 Opened 12 years ago Closed 12 years ago

Fix loading of config files into basic template

Categories

(Webmaker Graveyard :: Popcorn Maker, defect)

Product:
Webmaker Graveyard
Component:
Popcorn Maker
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: mjschranz, Assigned: mjschranz)

References

Details

Attachments

(1 file)

https://github.com/mozilla/popcorn.webmaker.org/pull/42
55 bytes, text/x-github-pull-request
humph
: review+
thecount
: review+
Details | Review
We missed one link. It loads /templates/basic and should be /editor
Summary: Change landing page link that jumps into APP → Fix loading of config files into basic template
In addition to the above, the loading of configs from /templates/basic needs to be fixed to accomodate the new url structure.
Comment on attachment 760205 [details] [review] https://github.com/mozilla/popcorn.webmaker.org/pull/42 This actually won't completely work at least with remixing and what not. I think I'm going to need to co-ordinate around the /edit and /remix stuff to properly figure this out.
Attachment #760205 - Flags: review?(jon) → review-
Depends on: 876457
Not really needed anymore with recent code that has landed.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Not fixed!
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 760205 [details] [review] https://github.com/mozilla/popcorn.webmaker.org/pull/42 Easiest way to test this is to use the two buttons on the landing page. One points to /templates/basic and the other points to the tutorial.json config. As an added bonus, adding ?savedDataUrl to /editor links now works too. IE: <HOSTNAME>/editor?savedDataUrl=tutorial.json
Attachment #760205 - Flags: review- → review?(david.humphrey)
Comment on attachment 760205 [details] [review] https://github.com/mozilla/popcorn.webmaker.org/pull/42 Looks sane to me, just one clarifying style change to make, noted in the PR. Adding Scott for an extra set of eyes before this lands.
Attachment #760205 - Flags: review?(scott)
Attachment #760205 - Flags: review?(david.humphrey)
Attachment #760205 - Flags: review+
Comment on attachment 760205 [details] [review] https://github.com/mozilla/popcorn.webmaker.org/pull/42 Just one nit, remove one line which is now dead code. Then land it.
Attachment #760205 - Flags: review?(scott) → review+
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: