Closed
Bug 880853
Opened 11 years ago
Closed 11 years ago
Fix loading of config files into basic template
Categories
(Webmaker Graveyard :: Popcorn Maker, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mjschranz, Assigned: mjschranz)
References
Details
Attachments
(1 file)
We missed one link. It loads /templates/basic and should be /editor
|
Assignee | |
Updated•11 years ago
|
Summary: Change landing page link that jumps into APP → Fix loading of config files into basic template
|
|
Assignee | |
Comment 1•11 years ago
|
||
In addition to the above, the loading of configs from /templates/basic needs to be fixed to accomodate the new url structure.
|
|
Assignee | |
Comment 2•11 years ago
|
||
Attachment #760205 -
Flags: review?(jon)
|
|
Assignee | |
Comment 3•11 years ago
|
||
Comment on attachment 760205 [details] [review] https://github.com/mozilla/popcorn.webmaker.org/pull/42 This actually won't completely work at least with remixing and what not. I think I'm going to need to co-ordinate around the /edit and /remix stuff to properly figure this out.
Attachment #760205 -
Flags: review?(jon) → review-
|
|
Assignee | |
Comment 4•11 years ago
|
||
Not really needed anymore with recent code that has landed.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 6•11 years ago
|
||
Comment on attachment 760205 [details] [review] https://github.com/mozilla/popcorn.webmaker.org/pull/42 Easiest way to test this is to use the two buttons on the landing page. One points to /templates/basic and the other points to the tutorial.json config. As an added bonus, adding ?savedDataUrl to /editor links now works too. IE: <HOSTNAME>/editor?savedDataUrl=tutorial.json
Attachment #760205 -
Flags: review- → review?(david.humphrey)
|
||
Comment 7•11 years ago
|
||
Comment on attachment 760205 [details] [review] https://github.com/mozilla/popcorn.webmaker.org/pull/42 Looks sane to me, just one clarifying style change to make, noted in the PR. Adding Scott for an extra set of eyes before this lands.
Attachment #760205 -
Flags: review?(scott)
Attachment #760205 -
Flags: review?(david.humphrey)
Attachment #760205 -
Flags: review+
|
||
Comment 8•11 years ago
|
||
Comment on attachment 760205 [details] [review] https://github.com/mozilla/popcorn.webmaker.org/pull/42 Just one nit, remove one line which is now dead code. Then land it.
Attachment #760205 -
Flags: review?(scott) → review+
|
||
Comment 9•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org https://github.com/mozilla/popcorn.webmaker.org/commit/81e53dbc7870f84efe6d1aa60a3fea203176e289 Fix Bug 880853 - Fix loading of configs with urls pointing to /templates/basic
|
|
||
Updated•11 years ago
|
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
|
|
||
Comment 10•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org https://github.com/mozilla/popcorn.webmaker.org/commit/81e53dbc7870f84efe6d1aa60a3fea203176e289 Fix Bug 880853 - Fix loading of configs with urls pointing to /templates/basic
|
||
Updated•11 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•