Add MOZ_FENNEC like MOZ_PHOENIX and MOZ_B2G

RESOLVED WONTFIX

Status

Firefox Build System
General
RESOLVED WONTFIX
5 years ago
4 months ago

People

(Reporter: jgilbert, Assigned: jgilbert)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 760015 [details] [diff] [review]
patch: Add a define for MOZ_FENNEC next to MOZ_PHOENIX and MOZ_B2G

I have need of defines which identify our products. We already have MOZ_PHOENIX for Desktop, and MOZ_B2G for FxOS, but nothing that I can find for just Mobile.
Attachment #760015 - Flags: review?
I've never liked MOZ_PHOENIX. What are you trying to do that you need it to be product-specific?

Updated

5 years ago
Blocks: 881277
(Assignee)

Comment 2

5 years ago
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #1)
> I've never liked MOZ_PHOENIX. What are you trying to do that you need it to
> be product-specific?

WebGL conformance for a platform gates allowing requests for 'webgl' instead of 'experimental-webgl'. Conformance is established on a per-product basis. As such, I need a way to differentiate whether we allow 'webgl' request based on the product.
It does sound like you want something platform specific, not product specific.
So typically we'd have a feature switch for this, MOZ_WEBGL_NON_EXPIRIMENTAL or something. If it really is set per-product (which seems weird), you'd set it in confvars.sh. If it's actually per-platform then you'd set it somewhere in configure.in.
(Assignee)

Comment 5

5 years ago
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #4)
> So typically we'd have a feature switch for this, MOZ_WEBGL_NON_EXPIRIMENTAL
> or something. If it really is set per-product (which seems weird), you'd set
> it in confvars.sh. If it's actually per-platform then you'd set it somewhere
> in configure.in.

Alright, that works too.
(Assignee)

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → WONTFIX
(Assignee)

Updated

5 years ago
Attachment #760015 - Flags: review?

Updated

4 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.