881026 - When using the get() api, canceling signin does not send a null assertion

Status: RESOLVED FIXED

(Core Graveyard :: Identity, defect)

Description

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Initially reported by :edmoz in https://github.com/mozilla/browserid/issues/3377

STR

1. goto firefoxos.myfavoritebeer.org
2. click on sign in button
3. click 'X' to cancel out of native UI

result: sign in button is disabled and greyed out
expected: it should be enabled and not greyed out

Comment 1

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Our recent KPI data collection indicates that way more people are still using the old get() and getVerifiedEmail() apis than we had anticipated, so I'm nomming this for v1.1.

Comment 2

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Attachment: Closing trusted UI cancels get()

The oncancel callback was wrongly in the watch options in the internal get() implementation.  Moved it to the request() options.

Comment 3

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

https://tbpl.mozilla.org/?tree=Try&rev=d9da0715699d

Comment 4

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

(In reply to Jed Parsons [:jparsons] from comment #3)
> https://tbpl.mozilla.org/?tree=Try&rev=d9da0715699d

Er, I don't understand how that try push included my patch for bug 875826; the only patch I had applied when I pushed was this one.  /me scratches head.

Comment 5

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

This will be testable in gaia with the UI Tests in bug 881435

Comment 6

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Here's tbpl again, this time with only the one patch
https://tbpl.mozilla.org/?tree=Try&rev=e68543cc9277

Comment 7

[Ben Adida [:benadida]]

Comment on attachment 760160 [details] [diff] [review]
Closing trusted UI cancels get()

Review of attachment 760160 [details] [diff] [review]:
-----------------------------------------------------------------

looks good

Comment 8

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

thanks, ben!

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/projects/birch/rev/59756b3204b0

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/59756b3204b0

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/a5881d10663e

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/a5881d10663e