881111 - [leo-pre-iot-br] label "just now" for call log is not localized

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Dialer, defect, P1)

Description

[David Palomino [:dpalomino]]

Device: leo
buildid: 20130529095707 (brazilian variant)

In the call log, the tag "just now" for quite recently calls, is not localized. Being the device configured in English, it just appears "just now" and not the Portuguese equivalent.

Comment 1

[gduan.moz]

looks like shared/locale/date properties files didn't set correctly.

Comment 2

[gduan.moz]

Which gaia version are you testing?

Comment 3

[Germán Toro del Valle (:gtorodelvalle)]

Hi guys! I just tried it with latest Gecko and Gaia from master (Gecko-c083ae2.Gaia-66e6719) and it reproduces.

The problem is the locale codes or properties we are using. Please, have a look at https://github.com/mozilla-b2g/gaia/blob/master/shared/locales/date/date.en-US.properties#L166 and https://github.com/mozilla-b2g/gaia/blob/master/shared/locales/date/date.fr.properties#L117 The Gaia code uses the 'en-US' version so I am updating all the related locales codes to this format.

Comment 4

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: Associated PR.

Additional note for the L10N guys: I also found more differences between the en-US locale file and the others. More concretely, all the 'weeks-ago-long', 'months-ago-long', 'years-ago-long', 'weeks-until-long', 'months-until-long' and 'years-until-long' entries only appear in the en-US version and not on the ar, fr or zh-TW locales. I guess this should be synchronized.

Comment 5

[Axel Hecht [:Pike]]

Comment on attachment 762607 [details]
Associated PR.

The localized files inside the gaia git repository are just for developers, they're not used for the actual builds.

I see little value in maintaining them in parts.

The real localizations come out of the repositories in http://hg.mozilla.org/gaia-l10n/ or their respective git mirrors.

Comment 6

[Germán Toro del Valle (:gtorodelvalle)]

Thanks Axel! Does it mean you will take care of updating whatever it is necessary in http://hg.mozilla.org/gaia-l10n/ based on my patch or should I take care of it? Thanks!

Comment 7

[Axel Hecht [:Pike]]

Your patch likely wouldn't apply. I'll wait for the localizers to take care of the strings.

Comment 8

[bhavana bajaj [:bajaj]]

This is a one-off localized bug that I saw a few days back and blocked on it thinking it missed translation.But,after getting in touch with the L10n team recently I have come to know that they are not localization complete for Pt-Br locale and so ideally this does not qualify as a blocker yet.Unsetting the flag.

Comment 9

[Germán Toro del Valle (:gtorodelvalle)]

Just pointing out that it won't work in any language but English since the locale strings (properties) are wrong in those locale files ;-)

Comment 10

[Germán Toro del Valle (:gtorodelvalle)]

Leaving the bug as unassigned since not currently working on it...

Comment 11

[Doug Sherk (:drs) (inactive)]

We verified that this is fixed on the lock screen, but we don't use this string anymore within the Dialer.