881137 - hdpi/xhdpi resolution assets and layout for Calendar app

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

This bug represents fixes needed in Calendar app in order to deliver bug 881126:

-- Have visual supply us with @1.5x and the correct @2x images.
-- On v1.1hd, modify CSS/JS so that apps will display @1.5x/@2x images correctly.
-- On master, drop the @1.5x and @2x images and make sure there is no
more to tweak besides changes made on bug 830644.

As HIDPI support never landed on v1-train, I expect the patch for both
branches on this bug will be different. The CSS/JS patch on v1.1hd will be based on the patch on master, but I won't expect it to be as simple as a |git cherry-pick|; so this is
where the engineering work lays.

The patch on top of v1-train should land on v1.1hd.

Comment 1

[Wayne Chang [:wchang]]

Setting hd+ for 1.1hd specific requirement

Comment 2

[Evan Tseng [:evanxd]]

Attachment: The PR is for master

Hi James,

Please help me review the patch.

This bug aims to achieve similar goal with bug 830644 on v1.1.0hd branch.

Since we need some specified step to try on WVGA device (partial can be tested
on Nightly), if you care about the changes and would like to do a full review,
you may set review flag after reviewing; otherwise, you may set feedback flag
and let me find an appropriate reviewer in Taipei to review and confirm on WVGA
device.

These 1.5x assets in patch are here temporarily for confirming we're making right layout changes, and will be replaced later after visual team supplying newly made 1.5x assets.

The step for testing by HD is noted in Github comment. Thanks a lot.

Comment 3

[James Lal [:lightsofapollo]]

Comment on attachment 770094 [details]
The PR is for master

I don't have a real device to test this against so I will assume that this works as in nightly ( which I did test ) and that it looks good there ( you did the testing ).

Nice work r=me

Comment 4

[James Lal [:lightsofapollo]]

in master: https://github.com/mozilla-b2g/gaia/commit/94a4360d93240d3255658ba65047808794da3cc6

Comment 5

[Evan Tseng [:evanxd]]

Comment on attachment 770094 [details]
The PR is for master

Hi Rex,

Please help review the path with the real device.

Thanks. :)

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

This bug has landed on master but not on v1.1.0hd. What happened?

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

I should leave this open ...

Comment 8

[Evan Tseng [:evanxd]]

Attachment: The PR is for v1.1.0hd

Hi James,

There are two patches for supporting hdpi resolution device.
This patch is specifically for v1.1.0hd branch.
And the PR https://github.com/mozilla-b2g/gaia/pull/10743 is for mater branch.

Please help me review the patch.
Thanks. :)

Comment 9

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 770816 [details]
The PR is for v1.1.0hd

Some comments on Github.
Please set review to me again once you finished it. Thank you!

Comment 10

[Evan Tseng [:evanxd]]

Comment on attachment 770816 [details]
The PR is for v1.1.0hd

Hi Rex,

I already updated for your comments in GitHub.
Please help me review patch.
Thanks. :)

Comment 11

[Evan Tseng [:evanxd]]

Attachment: The PR is for updating images in master branch

Hi Rex,

I already updated the images.
Please help me review the patch.

Thanks. :)

Comment 12

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 770816 [details]
The PR is for v1.1.0hd

Most of them seems good to me but I found a few layout breaking. See Github comments.
Please fix them and I'll r+ your patch. Thanks a lot!

Comment 13

[Evan Tseng [:evanxd]]

Hi Rex,

I already updated the PR for your comments.

And could you please help me review the PR in https://github.com/mozilla-b2g/gaia/pull/10805.

Thanks. :)

Comment 14

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 771561 [details]
The PR is for updating images in master branch

r=me

Thanks for updating this!

Comment 15

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 770816 [details]
The PR is for v1.1.0hd

See comments on Github. we can land this after you solve the white padding for dayView .
Thanks a lot!

Comment 16

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to KM Lee [:rexboy] from comment #15)
> Comment on attachment 770816 [details]
> The PR is for v1.1.0hd
> 
> See comments on Github. we can land this after you solve the white padding
> for dayView .
> Thanks a lot!

Evan, what stopped this from being landed?

Comment 17

[Evan Tseng [:evanxd]]

Hi Tim,


Sorry, I had no time to update the code for comments.

We had meeting whole day for Scrum planning meeting.

Ian and I just finished the discussion about Scrum planning meeting.

I would like to continue to code for comments now.

I think I could update the code for review later.

Comment 18

[Evan Tseng [:evanxd]]

Comment on attachment 770816 [details]
The PR is for v1.1.0hd

Hi Rex,

I already updated the code for your comments.

And I also fixed the while space in master branch with PR https://github.com/mozilla-b2g/gaia/pull/10805/files#L2R162.

Please help me review the patch.
Thanks. :)

Comment 19

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 770816 [details]
The PR is for v1.1.0hd

Looks perfect to me.

Thanks for your work!

Comment 20

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v1.1hd: https://github.com/mozilla-b2g/gaia/commit/1c42134a3d06501650b7d3a46c7eafd6dc9d26af
master (2nd parch): https://github.com/mozilla-b2g/gaia/commit/d31a5b25a436547d27b5f99e8a163d16d906ce61