881139 - hdpi/xhdpi resolution assets and layout for Clock app

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Clock, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

This bug represents fixes needed in Clock app in order to deliver bug 881126:

-- Have visual supply us with @1.5x and the correct @2x images.
-- On v1.1hd, modify CSS/JS so that apps will display @1.5x/@2x images correctly.
-- On master, drop the @1.5x and @2x images and make sure there is no
more to tweak besides changes made on bug 830644.

As HIDPI support never landed on v1-train, I expect the patch for both
branches on this bug will be different. The CSS/JS patch on v1.1hd will be based on the patch on master, but I won't expect it to be as simple as a |git cherry-pick|; so this is
where the engineering work lays.

The patch on top of v1-train should land on v1.1hd.

Comment 1

[Wayne Chang [:wchang]]

Setting hd+ for 1.1hd specific requirement

Comment 2

[[e-mail], [e-mail]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10719

Pointer to Github pull-request

Comment 3

[[e-mail], [e-mail]]

Comment on attachment 769601 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10719

WIP in master. I will file another pr for v1.1.0hd.

Comment 4

[[e-mail], [e-mail]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10722

Pointer to Github pull-request

Comment 5

[[e-mail], [e-mail]]

Comment on attachment 769634 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10722

Before kicking off reviewing I'd like to confirm things about review process:

1.What I added to this patch include css changes and @1.5x assets shrunk from @2x assets in master. These @1.5x assets are not the final version, and they are here just to confirm we have correct layout on HD devices. They should be replaced by newly drawn assets supplied by visual team later.

2. We need to test whether this patch work on HVGA(320x480), WVGA(480x800). Should we test for qHD(960x540) at this time too? We don't have appropriate devices on hand so this can only be confirmed using desktop / nightly.

3. If reviewer don't have HD devices, we may need to put some screenshot (specified by reviewer?) here to confirm whether we left something.

Comment 6

[[e-mail], [e-mail]]

Comment on attachment 769634 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10722

This bug aims to achieve similar goal with bug 830644 on hd1.1.0 branch.
Since we need some specified step to try on WVGA device (partial can be tested
on Nightly), if you care about the changes and would like to do a full review,
you may set review flag after reviewing; otherwise, you may set feedback flag
and let me find an appropriate reviewer in Taipei to review and confirm on WVGA
device.
These 1.5x assets in patch are here temporarily for confirming we're making right
layout changes, and will be replaced later after visual team supplied newly made
1.5x assets.
The step for testing in HD device / Nightly is noted in Github comment.

Thanks a lot! Feel free to ping me if you have any concerns.

Comment 7

[[e-mail], [e-mail]]

Comment on attachment 769601 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10719

The pr is requesting for merge in master. We don't plan to merge it to master. So, please ignore it.

Comment 8

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 769634 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10722

r=me. Looks good. Some comments on Github.
Thanks for the patch!

Comment 9

[[e-mail], [e-mail]]

Thanks for Rex's reviewing effort and be patient. We can close the issue since the pr is landed.

v1.1.0hd: e099a11ed798094a2b1d89401677c07efcb3c91d

Comment 10

[Tim Guan-tin Chien [:timdream] (please needinfo)]

https://github.com/mozilla-b2g/gaia/pull/10719

Where is the master patch for this bug?

Comment 11

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) from comment #0)
> -- On master, drop the @1.5x and @2x images and make sure there is no
> more to tweak besides changes made on bug 830644.

Comment 12

[[e-mail], [e-mail]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10782

Pointer to Github pull-request

Comment 13

[[e-mail], [e-mail]]

Comment on attachment 771178 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10782

Rex,
Could you please help to review the patch for master? Thanks.

Comment 14

[[e-mail], [e-mail]]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) from comment #10)
> https://github.com/mozilla-b2g/gaia/pull/10719
> 
> Where is the master patch for this bug?
Sorry, I misunderstand to fix the issue on v1.1.0hd only.:( So, I close pr 10719 before...

The pr 10782 is base on 10719 and revised nits according to Rex's comments of 10722.
Thanks for Tim's double check.

Comment 15

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 771178 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10782

Looks good to me. Just one nit error. See Github.

Thanks for the patch!

Comment 16

[[e-mail], [e-mail]]

(In reply to KM Lee [:rexboy] from comment #15)
> Looks good to me. Just one nit error. See Github.
> 
> Thanks for the patch!
Thanks for your review effort. I have updated it. Please help to check it again.

Comment 17

[[e-mail], [e-mail]]

master: d79496a50a78d6b8e57c5d499201299e8bdfeb96

Comment 18

[Rick Waldron [:rwaldron]]

Requesting leo+ because an leo+ patch depends on these changes

Comment 19

[bhavana bajaj [:bajaj]]

I am not sure why there would be a dependency here ? Could we not do a branch specific patch for 1.1 instead ?

Comment 20

[Preeti Raghunath(:Preeti)]

minus, please build branch specific patch for 1.1.