881143 - hdpi/xhdpi resolution assets and layout for Dialer app

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

This bug represents fixes needed in Dialer app in order to deliver bug 881126:

-- Have visual supply us with @1.5x and the correct @2x images.
-- On v1.1hd, modify CSS/JS so that apps will display @1.5x/@2x images correctly.
-- On master, drop the @1.5x and @2x images and make sure there is no
more to tweak besides changes made on bug 830644.

As HIDPI support never landed on v1-train, I expect the patch for both
branches on this bug will be different. The CSS/JS patch on v1.1hd will be based on the patch on master, but I won't expect it to be as simple as a |git cherry-pick|; so this is
where the engineering work lays.

The patch on top of v1-train should land on v1.1hd.

Comment 1

[Wayne Chang [:wchang]]

Setting hd+ for 1.1hd specific requirement

Comment 2

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: WIP for 1.1.0hd

Before kicking off reviewing I'd like to confirm things about review process:

1.What I added to this patch include css changes and @1.5x assets shrunk from @2x assets in master. These @1.5x assets are not the final version, and they are here just to confirm we have correct layout on HD devices. They should be replaced by newly drawn assets supplied by visual team later.

2. We need to test whether this patch work on HVGA(320x480), WVGA(480x800). Should we test for qHD(960x540) at this time too? We don't have appropriate devices on hand so this can only be confirmed using desktop / nightly.

3. If reviewer don't have HD devices, we may need to put some screenshot (specified by reviewer?) here to confirm whether we left something.

Comment 3

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 767156 [details]
WIP for 1.1.0hd

This bug aims to achieve similar goal with bug 830644 on hd1.1.0 branch.
Since we need some specified step to try on WVGA device (partial can be tested
on Nightly), if you care about the changes and would like to do a full review,
you may set review flag after reviewing; otherwise, you may set feedback flag
and let me find an appropriate reviewer in Taipei to review and confirm on WVGA
device.
These 1.5x assets in patch are here temporarily for confirming we're making right
layout changes, and will be replaced later after visual team supplied newly made
1.5x assets.
The step for testing in HD device / Nightly is noted in Github comment.

Thanks a lot! Feel free to ping me if you have any concerns.

Comment 4

[Germán Toro del Valle (:gtorodelvalle)]

Hi :rexboy , I'll contact Ismael (:basiclines) to ask him for support to review your patch and to learn the way to do it in the process. If this is urgent you may want to ask someone to review it for me ;-) I promise a review for next Monday the latest :-)

Comment 5

[Ismael Gonzalez [:basiclines]]

This is mostly images changes, will be enough to test it on a HIDPI device to see that all images have the desired dimensions.
This should be quick&easy review.

Great work Rex!

Comment 6

[Germán Toro del Valle (:gtorodelvalle)]

We'll do it tomorrow the latest... I swear, again! :-)

Comment 7

[Germán Toro del Valle (:gtorodelvalle)]

Already commented in the PR: https://github.com/mozilla-b2g/gaia/pull/10602 ;-)

Comment 8

[Germán Toro del Valle (:gtorodelvalle)]

Comment on attachment 767156 [details]
WIP for 1.1.0hd

After including the suggested comments, we are ready to go ;-) Thank you very much!

Comment 9

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Thank you so much German!

v1.1.0hd
https://github.com/mozilla-b2g/gaia/commit/a5c1b52fd131f9a8e3f357b400fbf9ebf8f44d67

Comment 10

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: patch for master

Hi German:
I cherry-picked the patch to master to sync @1.5x assets on both branches. (Same assets with just a few background-size statement)
It's almost the same with the hd patch one. May you help again? The bug can be closed after this PR.
Thanks a lot!

Comment 11

[Germán Toro del Valle (:gtorodelvalle)]

Comment on attachment 772540 [details]
patch for master

Hey! Just tested it in my Unagi setting the GAIA_DEV_PIXELS_PER_PX=1.5 and without setting it and works great! ;-) Great job :rexboy ;-)

Comment 12

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Thanks for your review German!

master:
https://github.com/mozilla-b2g/gaia/commit/0ef69589f547ae05020c1bc587844ebd9148b382