881147 - hdpi/xhdpi resolution assets and layout for FM Radio app

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::FMRadio, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

This bug represents fixes needed in FM Radio app in order to deliver bug 881126:

-- Have visual supply us with @1.5x and the correct @2x images.
-- On v1.1hd, modify CSS/JS so that apps will display @1.5x/@2x images correctly.
-- On master, drop the @1.5x and @2x images and make sure there is no
more to tweak besides changes made on bug 830644.

As HIDPI support never landed on v1-train, I expect the patch for both
branches on this bug will be different. The CSS/JS patch on v1.1hd will be based on the patch on master, but I won't expect it to be as simple as a |git cherry-pick|; so this is
where the engineering work lays.

The patch on top of v1-train should land on v1.1hd.

Comment 1

[Wayne Chang [:wchang]]

Setting hd+ for 1.1hd specific requirement

Comment 2

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: patch

This bug aims to achieve similar goal with bug 830644 on hd1.1.0 branch.
Since we need some specified step to try on WVGA device (partial can be tested
on Nightly), if you care about the changes and would like to do a full review,
you may set review flag after reviewing; otherwise, you may set feedback flag
and let me find an appropriate reviewer in Taipei to review and confirm on WVGA
device.
These 1.5x assets in patch are here temporarily for confirming we're making right
layout changes, and will be replaced later after visual team supplying newly made
1.5x assets.
The step for testing by HD is noted in Github comment. 
Thanks a lot! Feel free to ping me if you have any concerns.

Comment 3

[Pin Zhang [:pzhang] (inactive)]

> +  background: url(images/popup-texture.png) #272d32 repeat 0 0 / cover; 

The |popup-texture.png| has gradient transparent effect on the top half part of it, so if the antenna is unplugged, you can still see the frequency number that you currently played, I think it's part of UX design, then if you set background color with #272d32, the entire FM radio playing UI will be covered by the popup message.

I checked the repository, the background color is introduced by PR 8109[1], I have no idea why they did so, I prefer changing it back to |transparent|, @rexboy, if you have some other concerns, please let me know or double check with some UX guy.

[1] https://github.com/mozilla-b2g/gaia/pull/8109

Comment 4

[Pin Zhang [:pzhang] (inactive)]

(In reply to Pin Zhang [:pzhang] from comment #3)
> > +  background: url(images/popup-texture.png) #272d32 repeat 0 0 / cover; 
> 
> The |popup-texture.png| has gradient transparent effect on the top half part
> of it, so if the antenna is unplugged, you can still see the frequency
> number that you currently played, I think it's part of UX design, then if
> you set background color with #272d32, the entire FM radio playing UI will
> be covered by the popup message.
> 
> I checked the repository, the background color is introduced by PR 8109[1],
> I have no idea why they did so, I prefer changing it back to |transparent|,
> @rexboy, if you have some other concerns, please let me know or double check
> with some UX guy.
> 
> [1] https://github.com/mozilla-b2g/gaia/pull/8109

And the transparent effect of the background image is kind of a symmetry arc, so if we set to |cover|, the symmetry might break when it's scaled horizontally, how about 100% 100%?

Comment 5

[KM Lee [:rexboy] (inactivate after Sep. 22)]

OK I've made it transparent, see Github. The overlay looks better! :)

Also I think bookmark-button:hover background should be there so I updated it too[1]. Thank you!


https://github.com/mozilla-b2g/gaia/pull/10651/files#L0R118

Comment 6

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Thank you Pzhang!

v1.1.0hd
https://github.com/mozilla-b2g/gaia/commit/02a44f75b67d9b3fb72092e13e02ff7f357afbe4

Comment 7

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Set to fixed.

We still need to wait for updating assets.
For now I only got 1.5x icon of FM app from Patryck. I think it's better to update them together once all assets are ready.

Comment 8

[KM Lee [:rexboy] (inactivate after Sep. 22)]

master (@1.5x assets only)
https://github.com/mozilla-b2g/gaia/commit/530e1b568d1797a991ce23f2ee6702dd55227586


I'll fire another bug for tracing lacked assets.