hdpi/xhdpi resolution assets and layout for Keyboard app

VERIFIED FIXED

Status

Firefox OS
Gaia::Keyboard
VERIFIED FIXED
5 years ago
4 years ago

People

(Reporter: timdream, Assigned: rudyl)

Tracking

unspecified
x86
Mac OS X

Firefox Tracking Flags

(blocking-b2g:hd+, b2g-v1.1hd fixed)

Details

Attachments

(1 attachment)

This bug represents fixes needed in Keyboard app in order to deliver bug 881126:

-- Have visual supply us with @1.5x and the correct @2x images.
-- On v1.1hd, modify CSS/JS so that apps will display @1.5x/@2x images correctly.
-- On master, drop the @1.5x and @2x images and make sure there is no
more to tweak besides changes made on bug 830644.

As HIDPI support never landed on v1-train, I expect the patch for both
branches on this bug will be different. The CSS/JS patch on v1.1hd will be based on the patch on master, but I won't expect it to be as simple as a |git cherry-pick|; so this is
where the engineering work lays.

The patch on top of v1-train should land on v1.1hd.
Setting hd+ for 1.1hd specific requirement
blocking-b2g: hd? → hd+
Going to take care of keyboard app part. :)
Assignee: nobody → rlu
Created attachment 770785 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10766

Pointer to Github pull-request
Comment on attachment 770785 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10766

The work to sync up the CSS styles of keyboard app of v1.1 to Gaia master was done with Bug 888137.

So this patch only removed some unnecessary media query.

Rex,

Please help review this one.
Thanks.
Attachment #770785 - Flags: review?(rexboy)
Comment on attachment 770785 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10766

r=me

thanks for the patch!
Attachment #770785 - Flags: review?(rexboy) → review+
Landed to Gaia v1.1.0hd branch,
https://github.com/mozilla-b2g/gaia/commit/d628cd3b1534ffd72b0b8eea191484d32f540af2

Rex,

Thanks for the review.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
status-b2g-v1.1hd: --- → fixed
Resolution: --- → FIXED
Please note that Keyboard uses their own mechanism to be scaled up based on viewport width (js calculations).
This means that the keyboard will be "bigger" in Peak device (540x960) compared with Samsung Galaxy SII (480x800) even if we use 1.5x as gecko scaling factor because the resulting viewport on both devices respectively will be 360 and 320 (12.5% bigger on peak).
Just to keep it in mind!

Comment 8

5 years ago
Rudy, would you mind re-confirming this isn't necessary on master? Please reopen if it is.
Flags: needinfo?(rlu)
No, this patch is not needed for master because hi-res. support is done for Gaia master with Bug 860318.

Thanks.
Flags: needinfo?(rlu)

Updated

4 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.