881150 - hdpi/xhdpi resolution assets and layout for Keyboard app

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

This bug represents fixes needed in Keyboard app in order to deliver bug 881126:

-- Have visual supply us with @1.5x and the correct @2x images.
-- On v1.1hd, modify CSS/JS so that apps will display @1.5x/@2x images correctly.
-- On master, drop the @1.5x and @2x images and make sure there is no
more to tweak besides changes made on bug 830644.

As HIDPI support never landed on v1-train, I expect the patch for both
branches on this bug will be different. The CSS/JS patch on v1.1hd will be based on the patch on master, but I won't expect it to be as simple as a |git cherry-pick|; so this is
where the engineering work lays.

The patch on top of v1-train should land on v1.1hd.

Comment 1

[Wayne Chang [:wchang]]

Setting hd+ for 1.1hd specific requirement

Comment 2

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Going to take care of keyboard app part. :)

Comment 3

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10766

Pointer to Github pull-request

Comment 4

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 770785 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10766

The work to sync up the CSS styles of keyboard app of v1.1 to Gaia master was done with Bug 888137.

So this patch only removed some unnecessary media query.

Rex,

Please help review this one.
Thanks.

Comment 5

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 770785 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10766

r=me

thanks for the patch!

Comment 6

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Landed to Gaia v1.1.0hd branch,
https://github.com/mozilla-b2g/gaia/commit/d628cd3b1534ffd72b0b8eea191484d32f540af2

Rex,

Thanks for the review.

Comment 7

[Ismael Gonzalez [:basiclines]]

Please note that Keyboard uses their own mechanism to be scaled up based on viewport width (js calculations).
This means that the keyboard will be "bigger" in Peak device (540x960) compared with Samsung Galaxy SII (480x800) even if we use 1.5x as gecko scaling factor because the resulting viewport on both devices respectively will be 360 and 320 (12.5% bigger on peak).
Just to keep it in mind!

Comment 8

[Alex Keybl [:akeybl]]

Rudy, would you mind re-confirming this isn't necessary on master? Please reopen if it is.

Comment 9

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

No, this patch is not needed for master because hi-res. support is done for Gaia master with Bug 860318.

Thanks.