881151 - hdpi/xhdpi resolution assets and layout for Music app

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

This bug represents fixes needed in Music app in order to deliver bug 881126:

-- Have visual supply us with @1.5x and the correct @2x images.
-- On v1.1hd, modify CSS/JS so that apps will display @1.5x/@2x images correctly.
-- On master, drop the @1.5x and @2x images and make sure there is no
more to tweak besides changes made on bug 830644.

As HIDPI support never landed on v1-train, I expect the patch for both
branches on this bug will be different. The CSS/JS patch on v1.1hd will be based on the patch on master, but I won't expect it to be as simple as a |git cherry-pick|; so this is
where the engineering work lays.

The patch on top of v1-train should land on v1.1hd.

Comment 1

[Wayne Chang [:wchang]]

Setting hd+ for 1.1hd specific requirement

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Dominic, could you do it or reassign?

Comment 3

[Dominic Kuo [:dkuo]]

Yes, and if I cannot do it, I will reassign it to someone else, thanks.

Comment 4

[Dominic Kuo [:dkuo]]

Attachment: Adjust music layout to fit HD devices

Comment 5

[Dominic Kuo [:dkuo]]

Attachment: Add @1.5x images for master branch

Comment 6

[Dominic Kuo [:dkuo]]

Comment on attachment 771234 [details]
Adjust music layout to fit HD devices

Ismael,

I think Rex and you should be familiar with the Music patch in bug 830644, but currently Rex is reviewing almost all the patches for hd+, so you should be the best one to review my patch, would you please review this one, and the one for master branch as well? thanks.

Comment 7

[Dominic Kuo [:dkuo]]

Ismael, if you are also busy on reviewing the other patches, please let me know and I will find someone in Taipei to do it, thanks.

Comment 8

[Ismael Gonzalez [:basiclines]]

Comment on attachment 771234 [details]
Adjust music layout to fit HD devices

Everything looks perfect both on Peak and Unagi devices. Great work Dominic

Comment 9

[Dominic Kuo [:dkuo]]

Thanks Ismael!

Landed on v1.1.0hd: 1618ec29907f25a00dfa77d1d95a59c616504d36
Landed on master: b060f9d38a580c76ee4bfb9671a41898f5e86cb6