881163 - C++11 atomics fail to link with gcc 4.5.1

Status: RESOLVED FIXED

(Core :: MFBT, defect)

Description

[Timothy B. Terriberry (:derf)]

This produces many messages of the form

TestAtomics.o: In function `mozilla::detail::IntrinsicMemoryOps<int*, (mozilla::MemoryOrdering)2>::store(std::atomic<int*>&, int*)':
/home/derf/src/mozilla/mozilla-central/objdir-x86_64-unknown-linux-gnu/mfbt/tests/../../dist/include/mozilla/Atomics.h:222: undefined reference to `std::atomic<int*>::store(int*, std::memory_order)'

The upstream bug is <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45398>.

I can confirm linking succeeds on my machine with 4.5.2, but not on my machine with 4.5.1.

Comment 1

[Timothy B. Terriberry (:derf)]

Attachment: Require gcc 4.5.2 for C++11 atomics

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 760281 [details] [diff] [review]
Require gcc 4.5.2 for C++11 atomics

I don't think Waldo will object if I r+ this.

Comment 3

[Timothy B. Terriberry (:derf)]

Thanks!

https://hg.mozilla.org/mozilla-central/rev/7f45910089be