881209 - Scrolling in the variables view is much choppier after bug 760370

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[Victor Porof [:vporof][:vp]]

The .title:after rules introduced in bug 760370 seem to very obviously slow down scrolling, making it very choppy, at least on my machine (that fact that it's a retina display probably makes things much worse).

This can be easily optimized by not positioning things via pseudoclasses.

Comment 1

[Victor Porof [:vporof][:vp]]

Attachment: v1

Comment 2

[Victor Porof [:vporof][:vp]]

Comment on attachment 762723 [details] [diff] [review]
v1

Review of attachment 762723 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/netmonitor/netmonitor-view.js
@@ +48,3 @@
>  };
>  const GENERIC_VARIABLES_VIEW_SETTINGS = {
> +  lazyEmpty: true,

This was an unfortunate typo. See the property below.

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 762723 [details] [diff] [review]
v1

Review of attachment 762723 [details] [diff] [review]:
-----------------------------------------------------------------

I only have one question, but this looks great otherwise.

::: browser/devtools/shared/widgets/VariablesView.jsm
@@ +2408,5 @@
> +    tooltip.setAttribute("orient", "horizontal");
> +
> +    let labels = [
> +      "configurable", "enumerable", "writable",
> +      "frozen", "sealed", "extensible", "native-getter"];

Now the "N" symbol requires extra mental effort to parse, but it's probably offset by the decrease in the tooltip length.

::: browser/themes/osx/devtools/widgets.css
@@ -411,5 @@
>  }
>  
> -.variables-view-scope > .variables-view-element-details.enum:not(:empty) {
> -  border-bottom: 1px solid #ddd;
> -}

Why are you removing this, and why only on OS X?

Comment 4

[Victor Porof [:vporof][:vp]]

(In reply to Panos Astithas [:past] from com
> > -.variables-view-scope > .variables-view-element-details.enum:not(:empty) {
> > -  border-bottom: 1px solid #ddd;
> > -}
> 
> Why are you removing this, and why only on OS X?

Accident!

Comment 5

[Victor Porof [:vporof][:vp]]

Attachment: v1.1

Added the deleted rule again.

Comment 6

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/e2577d0fa093

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/e2577d0fa093