881218 - [Camera] Record of deleted videos are not updated in camera filmstrip

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect, P1)

Description

[Leo]

1. Title : Record of deleted videos are not updated in camera filmstrip
2. Precondition : Camera app and video player app should be working
3. Tester's Action : 1. Open camera -> record video -> minimize by pressing home button
                     2. Open video player -> delete the recorded video -> minimize video player app
                     3. Reopen camera app
 
4. Detailed Symptom (ENG.) : Deleted video is still shown in filmstrip

5. Expected : Record of deleted videos should be updated.
6.Reproducibility: Y
1)Frequency Rate : 100%
7.Gaia Master/v1-train : Reproduced
8.Gaia Revision: a25fb6bd1b0284ce3e197e88567d433c7815ee52
9.Personal email id: [e-mail]

Comment 1

[Mark Shiao]

Attachment: link to pull request

Hi Dominic,

Can you please review my patch?
My changes include adding 'changed' event listeners for device storage to both the gallery and camera app to react to delete events in video app. I've also change the filepath regex since the path actually starts with the storage device, ie sdcard.

Thanks,
Mark

Comment 2

[Ben Tian (inactive)]

Mark,

I think you only need to correct FROMCAMERA in video.js since both gallery and camera listen to video poster deletion [1].

[1] https://github.com/mozilla-b2g/gaia/blob/master/apps/video/js/video.js#L210

Comment 3

[Mark Shiao]

Hi Ben,

Thanks for the advice and I was able to spot the gallery and camera listeners for video poster deletion. 

I've update the pull request.

Thanks,
Mark

Comment 4

[Dominic Kuo [:dkuo]]

Comment on attachment 764651 [details]
link to pull request

Mark,

This is a simple patch and I have tested it so should be no problem.
r+ on github commit: 76d48125a11cdf0730e26c24f8ec3d31864abbc3
(I am r+ing on the second commit of you patch because they are not squashed yet)

Comment 5

[Mark Shiao]

landed on master commit# 9ec3c9a495c81c0ad7db5279a30c2cfa01d524a0
https://github.com/mozilla-b2g/gaia/commit/9ec3c9a495c81c0ad7db5279a30c2cfa01d524a0

Comment 6

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 9ec3c9a495c81c0ad7db5279a30c2cfa01d524a0 to:
v1-train: 338bb82cd43d24a63c6ecdf2adbfa14f3e842f46

Comment 7

[John Ford [:jhford] CET/CEST Berlin Time]

1.1hd: 338bb82cd43d24a63c6ecdf2adbfa14f3e842f46

Comment 8

[Parul Mathur]

Executed steps in Comment #1 and was able to reproduce on:
Device: Unagi phone
Build Identifier: 20130621070212
Update channel: unagi/1.1.0/beta
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/a34f6d62cb05
Platform information: 18.1
Gaia: cca61224e6df8e9f7e450d77cb6a8cf91029be641371823447
Git commit info: 2013-06-21 14:04:07
OS version: 1.1.0.0-prerelease

(see screenshot attached)

Comment 9

[Parul Mathur]

Attachment: screenshots of camera and video apps

In attached screenshot:
(1) Camera app after recording 4 videos. Notice that there are 4 video thunbnails showing in the filmstrip.
(2) Video app after deleting the 4 videos.
(3) Camera app opened after deleting the 4 videos. Notice that there are 4 video thunbnails showing in the filmstrip. The black screen occurs when a video thumbnail is tapped for playing.

Comment 10

[Mark Shiao]

Hi Parul,

I was unable to reproduce this issue.

I also tested the latest pvt build and everything seems to be working.

https://pvtbuilds.mozilla.org/pub/mozilla.org/b2g/nightly/mozilla-b2g18-unagi/latest/

Please let me know if you are still seeing the issue.

Thanks,
Mark

Comment 11

[Parul Mathur]

Hi Mark,

From your Comment #10 above, it's not clear which build you tested and what steps you followed. 
Please provide detailed information about the build tested (similar to Comment #8). 
Please also attach a video of your testing so that the steps to reproduce are clear. (For example https://bugzilla.mozilla.org/attachment.cgi?id=747281 in bug 869851)

Comment 12

[Mark Shiao]

Hi Parul,

Details of the build are below:

device: unagi
build identifier: 20130623070214
gecko: d7330ac47460d9ae7e2c2d0a8dc3d2d6679d1294
git commit date: 2013-06-22 08:45:35
git commit #: 11b472e74a2032ab56a984f07314654e21bb06f2
OS version : 1.1.0.0-prerelease
platform version: 18.1
update channel: unagi/1.1.0/beta

Steps used to reproduce: 
1) home button
2) open camera app
3) record 4 videos back-to-back
4) home button
5) open video app
6) delete 4 previously recorded videos
7) home button
8) open camera app
9) 4 recored videos no longer in filmstrip

Please let me know if the steps you mentioned are different from the steps I've taken.

Thanks,
Mark

Comment 13

[Corey Frang [:gnarf]]

I also can not reproduce this on v1-train unagi

Comment 14

[Parul Mathur]

Executed steps in Comment #0 and Comment #12 and was NOT able to reproduce on Unagi and Leo devices:

Device: Unagi phone
Build Identifier: 20130628070211
Update channel: unagi/1.1.0/beta
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/8d883cb49438
Platform information: 18.1
Gaia: c9e9b09cb181fcd15d12af09f89ff87f553c06c71372419157
Git commit info: 2013-06-28 11:32:37
OS version: 1.1.0.0-prerelease

Device: Leo phone
Build Identifier: 20130628070211
Update channel: leo/1.1.0/nightly 
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/8d883cb49438
Platform information: 18.1
Gaia: c9e9b09cb181fcd15d12af09f89ff87f553c06c71372419157
Git commit info: 2013-06-28 11:32:37
OS version: 1.1.0.0-prerelease