881248 - [MMS] Multirecipient. A contact with >1 number must only render the relevant number (vs. rendering all)

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[isabelrios]

Attachment: contact saved with two phone numbers

Bug seen on Unagi with today's build (06/10)
Gecko-b518de0
Gaia-aa166a4

PROCEDURE
Have one contact with two different phone numbers.
1. Create a new MMS
2. Tap into the 'To' field and type the contact name
3. Select the contact once
4. Select the contact again but with the other phone number

EXPECTED
The MMS in the origin appears as a MMS sent to two numbers

ACTUAL
The MMS in the origin seems to have sent to four numbers (twice for each contact's number)

Comment 1

[isabelrios]

Attachment: Two recipients but four numbers

Comment 2

[Rick Waldron [:rwaldron]]

Attachment: Fix for 881248

Comment 3

[Julien Wajsberg [:julienw]]

Comment on attachment 760554 [details] [review]
Fix for 881248

comments on the PR

Comment 4

[Julien Wajsberg [:julienw]]

Comment on attachment 760554 [details] [review]
Fix for 881248

r=me with the latest nit

Comment 5

[Rick Waldron [:rwaldron]]

Landed

Comment 6

[Rick Waldron [:rwaldron]]

Landedhttps://github.com/mozilla-b2g/gaia/commit/6406b9a535b5fcd7143a6ccb58c03a3a7b4296c5

Comment 7

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x  6406b9a535b5fcd7143a6ccb58c03a3a7b4296c5
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 8

[Julien Wajsberg [:julienw]]

part of conflict comes from the fact that bug 876754 is not leo+. The other conflicts are because Bug 882899 and Bug 881716 are not uplifted yet, I'm updting flags there.

Comment 9

[Julien Wajsberg [:julienw]]

Requested leo on bug 876754.

Comment 10

[Corey Frang [:gnarf]]

uplifted master: 6406b9a535b5fcd7143a6ccb58c03a3a7b4296c5
to v1-train: e6a24c1c14b9a55d0ae69468cf1f3a396d7ea20c

Comment 11

[John Ford [:jhford] CET/CEST Berlin Time]

v1.1.0hd: e6a24c1c14b9a55d0ae69468cf1f3a396d7ea20c

Comment 12

[isabelrios]

Verified with unagi v1-train 07/15 build:
Gecko-2b310a1
Gaia-d52ce22
ref ril

Comment 13

[sarsenyev]

Verified it's fixed on Leo V1.1 
When sending MMS to a one contact with 2 numbers, the MMS is sent and in the origin it shows as the MMS sent to the two different phone numbers

Environmental  Variables:
Build ID: 20130717070237
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/582e3a7018b0
Gaia: c506c50adaaebcf729ac3c27887ba2931ab79040
Platform Version: 18.1
RIL Version: 01.01.00.019.138