881276 - Update requests in requirements for webpay

Status: RESOLVED INVALID

(Marketplace Graveyard :: Payments/Refunds, defect, P4)

Description

[[e-mail]]

Attachment: Traceback

When I update deps locally for webpay I find I get errors relating to requests.

Updating requests with pip seems to solve the problem.

See attached traceback.

Comment 1

[[e-mail]]

See: https://github.com/mozilla/webpay/blob/master/requirements/prod.txt#L36 for the current version.

Comment 2

[Kumar McMillan [:kumar]]

Also maybe related: https://github.com/andymckay/curling/issues/3 (although as rob mentions perhaps it's not a valid issue)

Comment 3

[Kumar McMillan [:kumar]]

Stuart, make sure you are installing webpay with --no-deps like:

pip install --no-deps -r requirements/dev.txt --exists-action=w

Comment 4

[[e-mail]]

(In reply to Kumar McMillan [:kumar] from comment #3)
> Stuart, make sure you are installing webpay with --no-deps like:
> 
> pip install --no-deps -r requirements/dev.txt --exists-action=w

Yep that's exactly what I'm using.

Comment 5

[[e-mail]]

When running "pip install --no-deps -r requirements/dev.txt --exists-action=w" I see this in the output:

Downloading/unpacking requests==0.14.2 (from -r requirements/prod.txt (line 36))
  Using download cache from /home/tiffin/.pip/downloads/http%3A%2F%2Fpypi.python.org%2Fpackages%2Fsource%2Fr%2Frequests%2Frequests-0.14.2.tar.gz
  Running setup.py egg_info for package requests
    warning: no files found matching 'tests/*.'

Also once I've run the update on deps I confirm 0.14.2 was installed:

>>> import requests
>>> requests.__version__
'0.14.2'
>>> requests.__file__
'/home/tiffin/venv/webpay/lib/python2.6/site-packages/requests/__init__.pyc'

Comment 6

[[e-mail]]

Looking at the line referred to at the point of installation looks like we do have an explicit version listed at https://github.com/mozilla/webpay/blob/master/requirements/prod.txt#L36

Comment 7

[[e-mail]]

Tried this again recently and didn't notice the same problem. Marking as invalid for now.