"my makes" iframe loads a lot of things that are never shown to the user

RESOLVED WONTFIX

Status

RESOLVED WONTFIX
5 years ago
4 years ago

People

(Reporter: pomax, Assigned: pomax)

Tracking

Details

(Whiteboard: frontend, icebox)

(Assignee)

Description

5 years ago
loading up thimble and logging in loads the "my makes" iframe into the iframe.my-projects-iframe element, which in turn loads http://[webmaker.org]/myprojects?app=thimble&email=mypersonaemail, which loads way more HTML elements that are surfaced to the user. The entire footer is never shown, for instance, but loads a lot of image data.
Keywords: perf
Looks like the extra bit of UI is for when the me path is hit outside of the editor with no app.

So just go to webmaker.org/me and you'll see the other elements in use.
(Assignee)

Comment 2

5 years ago
this is correct, but it's also something that we can leave out of the /me response if it's for a specific app (it won't have the app=... query argument) so we can simply change the nunjucks template so that it only loads the header and footer in the response if there's no app argument, leading to a smaller file, and no mystery hidden content.
(Assignee)

Updated

5 years ago
Assignee: nobody → pomax
Status: NEW → ASSIGNED
(Assignee)

Comment 3

5 years ago
we can make parts of layout.html conditional on whether app equals 'webmaker' or not. If not, we can omit the header and footer entirely (as well as some of the js/css)
(Assignee)

Updated

5 years ago
Whiteboard: QA
(Assignee)

Updated

5 years ago
Whiteboard: QA → QA p=1 s=2013w27 u=dev
(Assignee)

Comment 4

5 years ago
unassigning pending reprioritisation
Assignee: pomax → nobody
Status: ASSIGNED → NEW

Comment 5

5 years ago
This is perf related, assigned to Gavin for triage
Assignee: nobody → gavin
Status: NEW → ASSIGNED
Keywords: perf
Whiteboard: QA p=1 s=2013w27 u=dev

Updated

5 years ago
Assignee: gavin → nobody
Whiteboard: frontend, icebox
(Assignee)

Updated

4 years ago
Assignee: nobody → pomax
(Assignee)

Comment 6

4 years ago
we don't have my makes iframe anymore.
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.