881310 - [sr] Add Serbian (Cyrillic) to languages-dev.json

Status: VERIFIED FIXED

(Firefox OS Graveyard :: GonkIntegration, defect)

Description

[Wilfred Mathanaraj [:WDM]]

As discussed with Axel logging a bug to add Serbian (Cyrillic) to the
languages-dev.json on master and v1-train.

This is blocking for partner to launch in Serbian speaking countries.

Comment 1

[Alex Keybl [:akeybl]]

Stas/Axel - can you reassign to whomever helped you all with these changes in the past? Thanks!

Comment 2

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

I can take this one since I worked on other Serbian locale related bugs (e.g. bug 872825, etc.)

Comment 3

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Attachment: Pull Request #10302 - Add Serbian (Cyrillic) to languages_dev.json

Add the "sr-Cyrl" entry to locales/languages_dev.json

Comment 4

[Axel Hecht [:Pike]]

Hal, do we need anything new in terms of mirroring for sr-Cyrl on the gaia side, and sr on the gecko side?

Comment 5

[Hal Wine [:hwine] use NI!]

To transition to including in languages_dev.json (which means the machinery will produce device builds for the locale), the following must all be true:

  Releng side:
   - the base gecko l10n hg repo must be converted/mirrored to git.m.o
   - the base gaia l10n hg repo must be converted/mirrored to git.m.o
  Dev side:
   - the gaia locale specified in gaia/locales/languages_dev.json
   - the gecko locale specified in gecko/b2g/locales/all-locales

For this case, none of these are in place. I'll open the requisite bugs for the repositories. Please don't commit the changes to the locale files until those repos are in place (it will break the device builds).

Comment 6

[Hal Wine [:hwine] use NI!]

the repository mirroring has been set up. Please go ahead and commit the locale file changes at your convenience.

Comment 7

[Staś Małolepszy :stas]

Landed on master:
https://github.com/mozilla-b2g/gaia/commit/65fdcf23f951a1591b1247d07f4c775fe5fe1a51

and on v1-train:
https://github.com/mozilla-b2g/gaia/commit/cdabd1e6e1fbf348ab21fe55e94ac7eed1c009a6

Thanks, Mihai and Hal for your help!

Comment 8

[Delphine Lebédel [:delphine - Use needinfo]]

Verified fixed on both master and v1-train

Comment 9

[John Ford [:jhford] CET/CEST Berlin Time]

1.1hd: cdabd1e6e1fbf348ab21fe55e94ac7eed1c009a6

Comment 10

[Axel Hecht [:Pike]]

Comment on attachment 760564 [details]
Pull Request #10302 - Add Serbian (Cyrillic) to languages_dev.json

stas actually reviewed this, so marking as such.

Comment 11

[Michael Vines [:m1] [:evilmachines]]

Should we add Serbian to languages_shira.json as well?  languages_dev.json is all-the-languages, were languages_shira.json is more directed at that particular market and could actually be used downstream.

Comment 12

[Wilfred Mathanaraj [:WDM]]

Yes we should add Serbian to languages_shira.jason as well.

Can we also confirm other languages are added to:

Hungarian
Greek
Czech
German

Comment 13

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

(In reply to Michael Vines [:m1] [:evilmachines] from comment #11)
> Should we add Serbian to languages_shira.json as well?  languages_dev.json
> is all-the-languages, were languages_shira.json is more directed at that
> particular market and could actually be used downstream.

(In reply to Wilfred Mathanaraj [:WDM] from comment #12)
> Yes we should add Serbian to languages_shira.jason as well.
> 
> Can we also confirm other languages are added to:
> 
> Hungarian
> Greek
> Czech
> German

fyi: our understanding was that languages_shira.json was obsolete, not being used anywhere, and to be deleted per bug#887037.


If I read this bug correctly, Serbian has been added to languages_dev.json already, so I think we're done here? What else needs to be done here?

Comment 14

[Michael Vines [:m1] [:evilmachines]]

languages_shira.json is probably obsolete for gaia master, but I think it might hold value in v1.1 as representing the set of !basecamp languages for that release. 

Or is the current thinking that downstream users must customize languages_dev.json for their target market manually?

Comment 15

[Axel Hecht [:Pike]]

I don't see any relevance to the term "basecamp" these days.

The languages on mozilla's side are in languages_dev.json. I don't see how we could scale subsets of that with the growing numbers of partners, and I'm not sure that it's the end-goal to have subsets for partners.

Comment 16

[Michael Vines [:m1] [:evilmachines]]

Ok, pushing this downstream works.  I'll just trying to clarify what the new policy is.  Thanks.