Closed
Bug 881321
Opened 11 years ago
Closed 7 years ago
"Write new message" entry in the contextual menu of the Mac OSX dock icon.
Categories
(Thunderbird :: OS Integration, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 56.0
People
(Reporter: feranick, Assigned: javirid)
References
(Blocks 1 open bug)
Details
Attachments
(2 files, 1 obsolete file)
20.65 KB,
image/png
|
Paenglab
:
ui-review+
|
Details |
3.40 KB,
patch
|
jorgk-bmo
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:21.0) Gecko/20100101 Firefox/21.0 (Beta/Release) Build ID: 20130511120803 Steps to reproduce: This bug is a feature request. When I click with the right button on the Thunderbird icon in the Mac OSX dock it would be very useful a menu entry to "WRITE new message" without enlarge thunderbird window. This is particularly useful since when a new message window is open, to write a new message many steps are required (right click on dock icon, select "Main window", wait for main window to open, etc...) Actual results: No entry for "Write new email". Expected results: An entry with "write new email" should be present in the OS X icon in the dock.
Comment 1•9 years ago
|
||
I'd like that feature too. Sounds simple enough, and would make TBird work as other apps (Firefox even has it).
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → leofigueres
Status: UNCONFIRMED → NEW
Ever confirmed: true
Version: 17 → Trunk
Assignee | ||
Comment 2•7 years ago
|
||
This is a screenshot which shows the new menu item in the macOS dock app icon. When it is selected, a new window is opened that allows user to write a new message. That window is opened alone, meaning, it will not open the main window if that wasn't already opened, making the process very fast. Default identity is selected by the mailServices module. The window for writing the new email is the one that mailServices is programmed to open. I think Blake was the one in charge of reviewing UI changes. So, could you take a look to this, Blake? Thank you.
Attachment #8885306 -
Flags: ui-review?(bwinton)
Comment 3•7 years ago
|
||
Comment on attachment 8885306 [details]
New item in dock popup menu
It was me a long time ago, but Paenglab is handling that kind of thing these days… (Also, I switched to Windows, so my sense of what the Mac should act like isn't the best. ;)
Attachment #8885306 -
Flags: ui-review?(bwinton) → ui-review?(richard.marti)
Comment 4•7 years ago
|
||
Comment on attachment 8885306 [details] New item in dock popup menu (In reply to Javi Rueda from comment #2) > Created attachment 8885306 [details] > New item in dock popup menu > > This is a screenshot which shows the new menu item in the macOS dock app > icon. > > When it is selected, a new window is opened that allows user to write a new > message. That window is opened alone, meaning, it will not open the main > window if that wasn't already opened, making the process very fast. The main window is not shown but when TB isn't started it starts TB first, correct? Or is the menu only shown when TB runs like Mail app? > Default identity is selected by the mailServices module. The window for > writing the new email is the one that mailServices is programmed to open. Like on Windows. Is there already a bug filed for adding a "Open address book" menu like Windows has?
Attachment #8885306 -
Flags: ui-review?(richard.marti) → ui-review+
Assignee | ||
Comment 5•7 years ago
|
||
(In reply to Richard Marti (:Paenglab) from comment #4) > > The main window is not shown but when TB isn't started it starts TB first, > correct? Or is the menu only shown when TB runs like Mail app? > The menu is only shown when the app is running: https://developer.apple.com/macos/human-interface-guidelines/menus/dock-menus/ > > Default identity is selected by the mailServices module. The window for > > writing the new email is the one that mailServices is programmed to open. > > Like on Windows. > > Is there already a bug filed for adding a "Open address book" menu like > Windows has? I haven't found any of that in tb-mac meta bug. There is one about adding "Get new messages" which I was going to be working next. However your proposal could be better as that is a Discover kind of item. If you prefer that feature implemented, I could work on it first, ibstead. I would also look if there is not an existing bug report, as I have not done any real search in Bugzilla.
Comment 6•7 years ago
|
||
A problem of "Get new messages" could be, it's not clear, does it only get the messages from active account, like the "Get Messages" button in main toolbar, or is it meant for all accounts. If it's the first, with the hidden window, how should the user know, which is the actual account? The latter could be problematic when a user doesn't want to check all accounts, for whatever reason. Then a configuration would be needed.
Assignee | ||
Comment 7•7 years ago
|
||
This is the patch for the currently accepted UI for this bug. I did a try-server run: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=c6e5791923d283003c9725f87c1696109ce5b8fc The failures in xpcshell tests seems to be happening for all the currently running commits, not only for this patch. (Sorry for the delay. The hard-drive on my Mac decided to corrupt itself between the time :Paenglab reviewed the UI part and the time I was to attach this patch) Currently I am not having too much luck when choosing the reviewers. Just guessing Magnus, as he was the latest reviewer for macMessengerOverlay.js file.
Attachment #8889684 -
Flags: review?(mkmelin+mozilla)
Comment 8•7 years ago
|
||
Comment on attachment 8889684 [details] [diff] [review] Patch Review of attachment 8889684 [details] [diff] [review]: ----------------------------------------------------------------- The code looks OK, r+ with the two nits fixed. Magnus doesn't have a Mac. So we'll get Richard to test it and then it can land. ::: mail/base/content/macMessengerOverlay.js @@ +71,5 @@ > + * Open a new window for writing a new message > + */ > +function writeNewMessageDock() > +{ > + Components.utils.import("resource:///modules/mailServices.js"); Please move the import to the top of the file. @@ +73,5 @@ > +function writeNewMessageDock() > +{ > + Components.utils.import("resource:///modules/mailServices.js"); > + > + // Default identity will be used as sender for the new message window Nit. Full stop after the comment.
Attachment #8889684 -
Flags: review?(mkmelin+mozilla) → review?(jorgk)
Comment 9•7 years ago
|
||
I fixed the nits myself since I need patches to land ;-) Richard can you please run this again before I land it.
Attachment #8889684 -
Attachment is obsolete: true
Attachment #8889684 -
Flags: review?(jorgk)
Attachment #8891526 -
Flags: review+
Comment 10•7 years ago
|
||
Tested it now and it does what the patch wants to do. :-)
Comment 11•7 years ago
|
||
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/1f0a3e17464f "Write new message" entry in the contextual menu of the Mac OSX dock icon. ui-r=Paenglab,r=jorgk
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Target Milestone: --- → Thunderbird 56.0
You need to log in
before you can comment on or make changes to this bug.
Description
•