Closed
Bug 881366
Opened 12 years ago
Closed 12 years ago
simplify CheckOverRecursed sequence
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: sunfish, Unassigned)
Details
Attachments
(1 file)
3.17 KB,
patch
|
sstangl
:
review+
|
Details | Diff | Splinter Review |
The CheckOverRecursed sequence currently loads the limit value into a register and then does a comparison and branch on it. On platforms like x86, the load can be folded into the comparison.
Reporter | ||
Comment 1•12 years ago
|
||
Attachment #760501 -
Flags: review?(sstangl)
Comment 2•12 years ago
|
||
Comment on attachment 760501 [details] [diff] [review]
a proposed fix
Review of attachment 760501 [details] [diff] [review]:
-----------------------------------------------------------------
In jscntxt.cpp:1084, there's a comment that reads "IonMonkey sets its stack limit to NULL to trigger operation callbacks."
Would you mind changing this comment to "...limit to UINTPTR_MAX to..." as part of this patch?
::: js/src/ion/CodeGenerator.cpp
@@ +2146,5 @@
> if (!addOutOfLineCode(ool))
> return false;
>
> // Conditional forward (unlikely) branch to failure.
> + masm.branchPtr(Assembler::Above, AbsoluteAddress(limitAddr), StackPointer,
AboveOrEqual?
@@ +2147,5 @@
> return false;
>
> // Conditional forward (unlikely) branch to failure.
> + masm.branchPtr(Assembler::Above, AbsoluteAddress(limitAddr), StackPointer,
> + ool->entry());
Coding style has 100 columns.
Attachment #760501 -
Flags: review?(sstangl) → review+
Reporter | ||
Comment 3•12 years ago
|
||
(In reply to Sean Stangl [:sstangl] from comment #2)
> Comment on attachment 760501 [details] [diff] [review]
> a proposed fix
>
> Review of attachment 760501 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> In jscntxt.cpp:1084, there's a comment that reads "IonMonkey sets its stack
> limit to NULL to trigger operation callbacks."
>
> Would you mind changing this comment to "...limit to UINTPTR_MAX to..." as
> part of this patch?
Done.
> ::: js/src/ion/CodeGenerator.cpp
> @@ +2146,5 @@
> > if (!addOutOfLineCode(ool))
> > return false;
> >
> > // Conditional forward (unlikely) branch to failure.
> > + masm.branchPtr(Assembler::Above, AbsoluteAddress(limitAddr), StackPointer,
>
> AboveOrEqual?
Oh yes, good catch.
> @@ +2147,5 @@
> > return false;
> >
> > // Conditional forward (unlikely) branch to failure.
> > + masm.branchPtr(Assembler::Above, AbsoluteAddress(limitAddr), StackPointer,
> > + ool->entry());
>
> Coding style has 100 columns.
Fixed.
https://hg.mozilla.org/integration/mozilla-inbound/rev/773df082bd35
Comment 4•12 years ago
|
||
Status: UNCONFIRMED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in
before you can comment on or make changes to this bug.
Description
•