split basic pred/succ checking out of AssertGraphCoherency

RESOLVED FIXED in mozilla24

Status

()

enhancement
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: sunfish, Unassigned)

Tracking

Trunk
mozilla24
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

AssertGraphCoherency contains code to check basic correspondence of predecessors and successors, and it also checks for RPO form. This means it can't be called in some places where the basic checking would still be useful, such as before SplitCriticalEdges.
Posted patch a proposed fix (obsolete) — Splinter Review
This patch splits the basic checking into a new function, AssertBasicGraphCoherency.
Attachment #760534 - Flags: review?(jdemooij)
Fix a minor error in previous patch description.
Attachment #760534 - Attachment is obsolete: true
Attachment #760534 - Flags: review?(jdemooij)
Attachment #760535 - Flags: review?(jdemooij)
Blocks: 881412
Attachment #760535 - Flags: review?(jdemooij) → review+
https://hg.mozilla.org/mozilla-central/rev/82add815a173
Status: UNCONFIRMED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.