Closed Bug 881409 Opened 8 years ago Closed 8 years ago

split basic pred/succ checking out of AssertGraphCoherency

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: sunfish, Unassigned)

References

Details

Attachments

(1 file, 1 obsolete file)

AssertGraphCoherency contains code to check basic correspondence of predecessors and successors, and it also checks for RPO form. This means it can't be called in some places where the basic checking would still be useful, such as before SplitCriticalEdges.
Attached patch a proposed fix (obsolete) — Splinter Review
This patch splits the basic checking into a new function, AssertBasicGraphCoherency.
Attachment #760534 - Flags: review?(jdemooij)
Attached patch an updated patchSplinter Review
Fix a minor error in previous patch description.
Attachment #760534 - Attachment is obsolete: true
Attachment #760534 - Flags: review?(jdemooij)
Attachment #760535 - Flags: review?(jdemooij)
Blocks: 881412
Attachment #760535 - Flags: review?(jdemooij) → review+
https://hg.mozilla.org/mozilla-central/rev/82add815a173
Status: UNCONFIRMED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.