881416 - SimplePush: Shutdown connections when in offline mode.

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

PushService monitors for network connection changes and tries to reconnect. When in offline mode PushService should shut down rather than repeatedly trying to reconnect.

Comment 1

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Attachment: Watch for offline status change

Comment 2

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Comment on attachment 760540 [details] [diff] [review]
Watch for offline status change

Review of attachment 760540 [details] [diff] [review]:
-----------------------------------------------------------------

Carrying forward r=jlebar from bug 867913

Comment 3

[Honza Bambas (:mayhemer)]

Comment on attachment 760540 [details] [diff] [review]
Watch for offline status change

Review of attachment 760540 [details] [diff] [review]:
-----------------------------------------------------------------

r=honzab

Just let you know that offline state automatic tracking is turned off on all desktop platforms from various reasons.

Comment 4

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

(In reply to Honza Bambas (:mayhemer) from comment #3)
> Comment on attachment 760540 [details] [diff] [review]
> Watch for offline status change
> 
> Review of attachment 760540 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r=honzab
> 
> Just let you know that offline state automatic tracking is turned off on all
> desktop platforms from various reasons.

By offline state tracking, do you mean using OS services to monitor actual network connection?

Comment 5

[Honza Bambas (:mayhemer)]

(In reply to Nikhil Marathe from comment #4)
> By offline state tracking, do you mean using OS services to monitor actual
> network connection?

Yes, a monitor checking for availability of a live connection or interface (e.g. on windows it monitors whether at least one NIC has been assigned an IP).

Comment 6

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/101be41e6536

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/101be41e6536