Closed Bug 881416 Opened 6 years ago Closed 6 years ago

SimplePush: Shutdown connections when in offline mode.

Categories

(Core :: DOM: Device Interfaces, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: nsm, Assigned: nsm)

References

Details

Attachments

(1 file)

PushService monitors for network connection changes and tries to reconnect. When in offline mode PushService should shut down rather than repeatedly trying to reconnect.
Comment on attachment 760540 [details] [diff] [review]
Watch for offline status change

Review of attachment 760540 [details] [diff] [review]:
-----------------------------------------------------------------

Carrying forward r=jlebar from bug 867913
Attachment #760540 - Flags: review?(nsm.nikhil) → review+
Comment on attachment 760540 [details] [diff] [review]
Watch for offline status change

Review of attachment 760540 [details] [diff] [review]:
-----------------------------------------------------------------

r=honzab

Just let you know that offline state automatic tracking is turned off on all desktop platforms from various reasons.
Attachment #760540 - Flags: review?(honzab.moz) → review+
Component: DOM → DOM: Device Interfaces
(In reply to Honza Bambas (:mayhemer) from comment #3)
> Comment on attachment 760540 [details] [diff] [review]
> Watch for offline status change
> 
> Review of attachment 760540 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r=honzab
> 
> Just let you know that offline state automatic tracking is turned off on all
> desktop platforms from various reasons.

By offline state tracking, do you mean using OS services to monitor actual network connection?
(In reply to Nikhil Marathe from comment #4)
> By offline state tracking, do you mean using OS services to monitor actual
> network connection?

Yes, a monitor checking for availability of a live connection or interface (e.g. on windows it monitors whether at least one NIC has been assigned an IP).
https://hg.mozilla.org/mozilla-central/rev/101be41e6536
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.