881453 - [AccessFu] Cancel both touch and mouse events all the time

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Eitan Isaacson [:eeejay]]

On desktop, the desktop-helper extension in Gaia translates mouse events to touch events, unless there are mouse listeners, then it uses mouse events. Bottom line: We need to block both touch and mouse events.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Block both mouse and touch events in touch adapter.

Comment 2

[Eitan Isaacson [:eeejay]]

Attachment: Bug 881453 - Block both mouse and touch events in touch adapter.

I took some of your input, and did some testing. In gonk (b2g devices), we get concurrent mouse and touch events. So we should only use touch events. I added the widgetToolkit as a cleaner way to get what we want. I also removed the glass element, as far as I can tell this patch solves that issue. It was a horrible hack.

Comment 3

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 761087 [details] [diff] [review]
Bug 881453 - Block both mouse and touch events in touch adapter.

Review of attachment 761087 [details] [diff] [review]:
-----------------------------------------------------------------

r=me Looks awesome :)

::: accessible/src/jsat/TouchAdapter.jsm
@@ +109,5 @@
> +          'mousedown' : true,
> +          'mouseup': true,
> +          'click': false };
> +        if ('ontouchstart' in Utils.win) {
> +          for each (let eventType in ['touchstart', 'touchmove', 'touchend']) {

Nit:

Looks like for each...in is deprecated, this should do the same:

for (let eventType of ['touchstart', 'touchmove', 'touchend']) {...}

Comment 4

[Eitan Isaacson [:eeejay]]

(In reply to Yura Zenevich [:yzen] from comment #3)
> Nit:
> 
> Looks like for each...in is deprecated, this should do the same:
> 
> for (let eventType of ['touchstart', 'touchmove', 'touchend']) {...}

Very good to know that!

Comment 5

[Eitan Isaacson [:eeejay]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/58e071c453ef

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/58e071c453ef