881457 - Switch webmaker.org over to app tags for featured makes

Status: RESOLVED FIXED

(Webmaker Graveyard :: webmaker.org, defect)

Description

[Chris DeCairos (:cade)]

It's currently using raw tags (i.e. those which do not contain a ':' - "featured"). In order to ensure that not just anyone can get their content on the front page of webmaker.org, we need to use app tags (Those which are prefixed by a ':' - "webmaker:featured")

Comment 1

[Chris DeCairos (:cade)]

Attachment: https://github.com/mozilla/webmaker.org/pull/107

I think I got most, if not all of them, but you know this repo better than me, so lets confirm we got everything.

Comment 2

[Chris DeCairos (:cade)]

Keep in mind we're going to have to sift through staging and update all the projects using the raw "[ featured, guide, recommended ]" tag to "webmaker:[ featured, guide, recommended ]"

Comment 3

[inactivate account for kate]

Comment on attachment 760939 [details] [review]
https://github.com/mozilla/webmaker.org/pull/107

My only concern here is that everywhere we check for guides we will have to check for both webmaker:guide and guide, which will complicate code paths like this for example: https://github.com/mozilla/webmaker.org/blob/master/lib/makeapi-webmaker.js#L25

Personally I think [ webmaker:featured + guide ] is a better way to filter the front page rather than having to update all of our code paths, but if you are going to do it that way, you should update:

https://github.com/mozilla/webmaker.org/blob/master/lib/makeapi-webmaker.js#L25
https://github.com/mozilla/webmaker.org/blob/master/public/js/base/mediaGallery.js#L53

Comment 4

[Chris DeCairos (:cade)]

My one objection to that is that relying on raw tags for our main search combinations may cause us headaches in the future

Imagine a user makes a guide using thimble tags it "guide"
We discover it through social media or some other mechanism and add "webmaker:featured" because it's awesome.
The next day/week/whenever, they delete the guide tag, whether accidentally or on purpose and updates their make.
The make disappears from our page because it no longer satisfies the search criteria.

If we use "webmaker:guide" then the make can only be removed if the user deletes it outright or requests directly that it not be shown. At least in this case we have some more control over when things disappear from our front page.

Comment 5

[Chris DeCairos (:cade)]

Comment on attachment 760939 [details] [review]
https://github.com/mozilla/webmaker.org/pull/107

I changed my mind on "webmaker:guide"

Reverted it back to just "guide". featured / recommended guides will be tagged with the corresponding app tag rather than also having to include another app tag.

Comment 6

[inactivate account for kate]

Comment on attachment 760939 [details] [review]
https://github.com/mozilla/webmaker.org/pull/107

Nice

Comment 7

[[github robot]]

Commit pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/5583ca31d80e5a34356d9b403fdf0605644d5539
Fix Bug 881457 - Use App tags on webmaker.org