Closed
Bug 881483
Opened 11 years ago
Closed 11 years ago
[OS.File] Substitute noOptions constant with the object literal.
Categories
(Toolkit Graveyard :: OS.File, defect)
Toolkit Graveyard
OS.File
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla24
People
(Reporter: yzen, Assigned: yzen)
References
Details
Attachments
(1 file)
|
19.59 KB,
patch
|
Yoric
:
review+
|
Details | Diff | Splinter Review |
This is necessary to eliminate the existing fragility where an OS.File operation augments the empty (noOptions) options object.
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → yura.zenevich
|
|
Assignee | |
Comment 1•11 years ago
|
||
Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=335df4397713
Attachment #760738 -
Flags: review?(dteller)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 760738 [details] [diff] [review] Patch for 881483 v1 Review of attachment 760738 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, thanks.
Attachment #760738 -
Flags: review?(dteller) → review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/57c8642772b5
Keywords: checkin-needed
|
|
||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/57c8642772b5
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
|
||
Updated•11 months ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•