881557 - [socorro-crashstats] topcrash signatures should only consider "correlation OS"

Status: RESOLVED INVALID

(Socorro :: Webapp, task)

Description

[Robert Helmer [:rhelmer]]

This should show the whole signature, and it also breaks correlations (which perhaps should be using a custom attribute)

Comment 1

[Robert Helmer [:rhelmer]]

Ah! I am wrong about the problem here - has nothing to do with truncation. The problem is that correlation reports in the UI are intended to identify the top OS for each signature and only show reports on that, and the /correlation/signature call from topcrasher report (which determines if a signature is valid or not) is currently passing all OSes, while the following call to /ccorrelation is only passing the "correlation OS".

One way to fix this is to change the way rows are iterated over in the topcrash page.

Comment 3

[Robert Helmer [:rhelmer]]

Not actively working on this, I think it might be fixed in the django app though.

Comment 4

[Scoobidiver (away)]

(In reply to Robert Helmer [:rhelmer] from comment #3)
> I think it might be fixed in the django app though.
It's not fixed. On Firefox 22 Top Crashers and Crash Reports for a signature, there are no correlations for je_free | DefaultFreeEntry, RtlpAllocateHeap | CContext::PerformAmortizedRenderOperations(), @0x0 | CClientContextActivator::CreateInstance(IUnknown*, IActivationPropertiesIn*, IActivationPropertiesOut**), __RtlUserThreadStart | _RtlUserThreadStart, @0x0 | PRMJ_Now(), etc. while there are in correlation files.

Comment 5

[Peter Bengtsson [:peterbe]]

Top Crasher has been completely rewritten and as far as I know the correlations tab works as expected now.