If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

PJS: Add Array.length stub for ParallelGetPropertyIC

RESOLVED FIXED in mozilla25

Status

()

Core
JavaScript Engine
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: shu, Assigned: shu)

Tracking

unspecified
mozilla25
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

4 years ago
Needed for GetElementIC to be useful.
(Assignee)

Comment 1

4 years ago
Created attachment 760679 [details] [diff] [review]
v0
Assignee: general → shu
Attachment #760679 - Flags: review?(nicolas.b.pierron)
Comment on attachment 760679 [details] [diff] [review]
v0

Review of attachment 760679 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ion/IonCaches.cpp
@@ +1641,5 @@
> +
> +bool
> +ParallelGetPropertyIC::attachArrayLength(LockedJSContext &cx, IonScript *ion, JSObject *obj)
> +{
> +    JS_ASSERT(!idempotent());

Is that even possible with parallel ICs?
Attachment #760679 - Flags: review?(nicolas.b.pierron) → review+
(Assignee)

Comment 3

4 years ago
Created attachment 765078 [details] [diff] [review]
Part 1: Support Array.length in GetPropertyPure
Attachment #765078 - Flags: review?(bhackett1024)
(Assignee)

Comment 4

4 years ago
Created attachment 765079 [details] [diff] [review]
Part 2: Ion changes

Carrying r+ from nbp, only changes were to VM functions, which I separated out as a the part 1 patch.
Attachment #760679 - Attachment is obsolete: true
Attachment #765079 - Flags: review+
(Assignee)

Updated

4 years ago
Blocks: 881536
Attachment #765078 - Flags: review?(bhackett1024) → review+
(Assignee)

Comment 5

4 years ago
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/e74c9ba1d0fa
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/decd395b3be9
https://hg.mozilla.org/mozilla-central/rev/e74c9ba1d0fa
https://hg.mozilla.org/mozilla-central/rev/decd395b3be9
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.