881595 - Prevent ugly error with duplicate titles

Status: RESOLVED FIXED

(Webmaker Graveyard :: Thimble, defect)

Description

[Brett Gaylor [:brett]]

Currently if you try and create a new make with a title identical to a make in your dashboard, thimble throws a gnarly error that includes:
"Sorry, an error occurred while trying to publish. Error: You already have a page named test at /var/www/thimble"

Lets replace this with a more friendly dialogue that says "You already have a make with this name.  Please choose another title using the <title> tag" and exclude the extraneous error messages.

Comment 1

[Pomax]

agreed. There's also https://bugzilla.mozilla.org/show_bug.cgi?id=873499, which is the more general "clean up our errors", but doing them on a case by case basis lets us track better. Marking as blocking 881595, if you run across other errors that have bad error messages, too, please file those as well and assign to me.

Comment 2

[Pomax]

Attachment: https://github.com/mozilla/thimble.webmaker.org/pull/109

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/thimble.webmaker.org

https://github.com/mozilla/thimble.webmaker.org/commit/cacb1bd645c4ea73478a296c4ddc10e0a847dd38
Merge pull request #109 from Pomax/bug881595

turned Error object into string error