If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Set the URL in finalizeProject so we can get make details later

RESOLVED FIXED

Status

Webmaker
Thimble
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: inactivate account for kate, Assigned: inactivate account for kate)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Right now we don't have a way to reliably search for thimble makes inside of make details, so let's restructure the URL creation logic so we have it before we render it.
(Assignee)

Comment 1

4 years ago
Created attachment 760742 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/107
Attachment #760742 - Flags: review?(pomax)
Comment on attachment 760742 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/107

you can already get the make details, because we publish the make after we already have the published URL. If this solves a different problem, please update the ticket title/explanation.
Attachment #760742 - Flags: review?(pomax) → review-
(Assignee)

Comment 3

4 years ago
Comment on attachment 760742 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/107

I updated with some comments and a little clearer path, also included the appName variable
Attachment #760742 - Flags: review- → review?(pomax)
Comment on attachment 760742 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/107

comments in the pull request, mostly we can turn the generateUrls function into a middleware function now, that we can simply stick in the route's middleware cascade.
Attachment #760742 - Flags: review?(pomax) → review-
(Assignee)

Comment 5

4 years ago
Comment on attachment 760742 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/107

Nice, good suggestion
Attachment #760742 - Flags: review- → review?
(Assignee)

Updated

4 years ago
Attachment #760742 - Flags: review? → review?(pomax)
Comment on attachment 760742 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/107

small nit, to turn a require into a one-time require, rather than making it rerequire on every call
Attachment #760742 - Flags: review?(pomax) → review-
(Assignee)

Updated

4 years ago
Attachment #760742 - Flags: review- → review?
(Assignee)

Updated

4 years ago
Attachment #760742 - Flags: review? → review?(pomax)
Comment on attachment 760742 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/107

Nice, R+
Attachment #760742 - Flags: review?(pomax) → review+

Comment 8

4 years ago
Commit pushed to master at https://github.com/mozilla/thimble.webmaker.org

https://github.com/mozilla/thimble.webmaker.org/commit/4e13b8f2adfde6d89513b5f9bd7412763984f32b
[bug 881598 ] Do url creation logic before publish happens
this landed.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.