881598 - Set the URL in finalizeProject so we can get make details later

Status: RESOLVED FIXED

(Webmaker Graveyard :: Thimble, defect)

Description

[inactivate account for kate]

Right now we don't have a way to reliably search for thimble makes inside of make details, so let's restructure the URL creation logic so we have it before we render it.

Comment 1

[inactivate account for kate]

Attachment: https://github.com/mozilla/thimble.webmaker.org/pull/107

Comment 2

[Pomax]

Comment on attachment 760742 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/107

you can already get the make details, because we publish the make after we already have the published URL. If this solves a different problem, please update the ticket title/explanation.

Comment 3

[inactivate account for kate]

Comment on attachment 760742 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/107

I updated with some comments and a little clearer path, also included the appName variable

Comment 4

[Pomax]

Comment on attachment 760742 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/107

comments in the pull request, mostly we can turn the generateUrls function into a middleware function now, that we can simply stick in the route's middleware cascade.

Comment 5

[inactivate account for kate]

Comment on attachment 760742 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/107

Nice, good suggestion

Comment 6

[Pomax]

Comment on attachment 760742 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/107

small nit, to turn a require into a one-time require, rather than making it rerequire on every call

Comment 7

[Pomax]

Comment on attachment 760742 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/107

Nice, R+

Comment 8

[[github robot]]

Commit pushed to master at https://github.com/mozilla/thimble.webmaker.org

https://github.com/mozilla/thimble.webmaker.org/commit/4e13b8f2adfde6d89513b5f9bd7412763984f32b
[bug 881598 ] Do url creation logic before publish happens

Comment 9

[Pomax]

this landed.