881601 - JavaScript Error: "this._marionetteServer is undefined"

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Justin Dolske [:Dolske]]

My Windows build (current mozilla-central) is throwing this exception when I quit:

************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "'[JavaScript Error: "this._marionetteServer is undefined" {file:
"file:///d:/mozilla-central/obj/dist/bin/components/marionettecomponent.js" line
: 140}]' when calling method: [nsIObserver::observe]"  nsresult: "0x80570021 (NS
_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "native frame :: <unknown
filename> :: <TOP_LEVEL> :: line 0"  data: yes]
************************************************************

Line 140 is the closeListener call:

  uninit: function mc_uninit() {
    this._marionetteServer.closeListener();
    this._loaded = false;
  },


[Aside, MXR seems busted at the moment, it's view of https://mxr.mozilla.org/mozilla-central/source/testing/marionette/components/marionettecomponent.js is months and 4 changesets out-of-date. Whuck.]

Comment 1

[Jonathan Griffin (:jgriffin)]

Attachment: Don't close the listener if it was never opened,

Comment 2

[William Lachance (:wlach)]

Comment on attachment 762039 [details] [diff] [review]
Don't close the listener if it was never opened,

lgtm

Comment 3

[William Lachance (:wlach)]

(In reply to Justin Dolske [:Dolske] from comment #0)

> [Aside, MXR seems busted at the moment, it's view of
> https://mxr.mozilla.org/mozilla-central/source/testing/marionette/components/
> marionettecomponent.js is months and 4 changesets out-of-date. Whuck.]

DXR seems to be up-to-date, and is faster to boot: 

http://dxr.mozilla.org

:)

Comment 4

[Jonathan Griffin (:jgriffin)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/da56c7a59b9e

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/da56c7a59b9e