881608 - OdinMonkey: "Assertion failure: false (Unexpected argument type)" passing unknown around

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jesse Ruderman]

(function(stdlib, foreign) {
  "use asm";
  var identity = foreign.identity;
  function f()
  {
    return identity(identity(0)) | 0;
  }
  return f;
})(this, {identity:function(x){return x}})


Assertion failure: false (Unexpected argument type), at js/src/ion/x64/Assembler-x64.cpp:71


The first bad revision is:
changeset:   http://hg.mozilla.org/integration/mozilla-inbound/rev/9ce9c145e072
user:        Luke Wagner
date:        Mon Jun 10 16:21:21 2013 -0700
summary:     Bug 878526 - OdinMonkey: handle 'unknown' type properly for FFI functions with unused results (r=bbouvier)

Comment 1

[Luke Wagner [:luke]]

Attachment: fix and test

Oops, there was an implicit case analysis in CheckCallArgs that was missed when adding Type::Unknown.

Comment 2

[Benjamin Bouvier [:bbouvier] (inactive)]

Comment on attachment 760934 [details] [diff] [review]
fix and test

Review of attachment 760934 [details] [diff] [review]:
-----------------------------------------------------------------

Nice catch.

Comment 3

[Luke Wagner [:luke]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/acda9f185e0b

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/acda9f185e0b