Closed Bug 881624 Opened 7 years ago Closed 7 years ago

Use textwrap on mach's need-to-clobber help output

Categories

(Firefox Build System :: Mach Core, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla24

People

(Reporter: Six, Assigned: Six)

References

Details

Attachments

(1 file, 1 obsolete file)

mach's need-to-clobber help output was too long (Bug 878861).
Use textwrap to definitly fix this.
Attachment #761085 - Flags: review?(gps)
Comment on attachment 761085 [details] [diff] [review]
Use Textwrap on mach's need-to-clobber help output

Review of attachment 761085 [details] [diff] [review]:
-----------------------------------------------------------------

::: python/mozbuild/mozbuild/controller/clobber.py
@@ +14,3 @@
>  
> +CLOBBER_MESSAGE = TextWrapper(subsequent_indent="* ", drop_whitespace=True, \
> +                                  replace_whitespace=False).fill('''

Can we not remove most of the '*' from the string and rely on subsequent_indent to create them?

Perhaps we should just remove '*'. IIRC they were carried over from a day when the clobber code was in other parts of the build system and didn't stand out easily. Now that clobber is tested earlier in the build, they may not be needed...
Attachment #761085 - Flags: review?(gps) → feedback+
OK
i removed all '*', it looks nicer than my previous patch
Attachment #761085 - Attachment is obsolete: true
Attachment #761346 - Flags: review?(gps)
Comment on attachment 761346 [details] [diff] [review]
Use Textwrap on mach's need-to-clobber help output (2nd version)

Review of attachment 761346 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me!
Attachment #761346 - Flags: review?(gps) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/0b35a9fc88b8
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.