881629 - [socorro-crashstats] Report drop down menu resets Version menu

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Scoobidiver (away)]

Once a version is selected, trying to change the view with the Report drop down menu resets the version.

Comment 1

[Robert Helmer [:rhelmer]]

OK this is a pretty easy fix, mostly by removing legacy code and moving the version logic into the template.

However, there is one caveat - both the "Crasher per User" and "Nightly Builds" will not preserve this version info. This is because the former can take more than one version (and uses GET params not the URL like other reports) and the latter does not allow specifying version at all, so these two will reset version (although it'll work for setting the graph at least in "Crashes per User", it just won't be preserved in the menu.

Also, topcrasher has a "magical" feature where it tries to select the top version if no version is selected, so this makes testing confusing.

Comment 2

[Robert Helmer [:rhelmer]]

r? https://github.com/mozilla/socorro-crashstats/pull/372

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro-crashstats

https://github.com/mozilla/socorro-crashstats/commit/fecd01dc1c79ad2ed8245326d63a1e2aa2026e77
bug 881629 - report dropdown should not reset version

https://github.com/mozilla/socorro-crashstats/commit/7b26f4b886a3ca47959ce8870ba8e407024a035a
Merge pull request #372 from rhelmer/bug881629-report-dropdown-resets-version

bug 881629 - report dropdown should not reset version

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro-crashstats

https://github.com/mozilla/socorro-crashstats/commit/5393199a7f24a4c069cd5125b1de8a376d1127b7
Revert "bug 881629 - report dropdown should not reset version"

This reverts commit fecd01dc1c79ad2ed8245326d63a1e2aa2026e77.