881648 - [MMS] There is not maximum limit warning

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[isabelrios]

Unagi 06/11 build:
Gecko-68ad212
Gaia-ea18de8

PROCEDURE
1. Start composing a MMS 
2. Attach a picture and a wallpaper (Total size bigger than 500Kb)
3. Send it

EXPECTED
Depending on the limit set, the MMS is sent, resize and sent or there is a warning message to user 'File too big' Pag #34 HTML5_SMS-MMSUserStorySpecifications_20130503_V8.0

ACTUAL
Attaching a picture from Camera: 448.3Kb and a wallpaper: 14.8Kb, total: 463.1Kb, the MMS is sent.
Attaching a picture from Camera: 446.3Kb and a wallpaper: 66.3Kb, total: 514.6Kb, the MMS is not sent.
The error on the MMS only gives possibilities to try agai or cancel. Trying again, the MMS is never sent.

Comment 1

[Alex Keybl [:akeybl]]

Marking this as late-l10n, because it's not clear if this requires new strings. Please confirm.

Comment 2

[Alex Keybl [:akeybl]]

Given no comment, I'm assuming this will require new strings. Since this is late-l10n, throwing into the QE3 milestone to ensure we resolve with time to localize.

Comment 3

[[e-mail], [e-mail]]

Attachment: The file you have selected is too large.

The screen shot is showing after user attached a file over size limitation.

Comment 4

[[e-mail], [e-mail]]

Attachment: You've exceeded the maxmum length.

The screen shot is showing after user attached a file in range of limitation. But the total size of composing attached files is over the limitation.

Comment 5

[[e-mail], [e-mail]]

The root cause is that no one to set the settings key "dom.mms.operatorSizeLimitation" and correspond to carries' limitation. And the default value is zero as following.. 
https://github.com/mozilla-b2g/gaia/blob/master/build/settings.py#L124

I also try to give the key with value 300. The functionality works for me as the attached screen shot.

I guess that we will set the value of "operatorSizeLimitation" via customization progress. Does anyone know the plan for the section? I didn't join the discussion before.

Comment 6

[[e-mail], [e-mail]]

(In reply to Ian Liu [:ianliu] from comment #5)
> I guess that we will set the value of "operatorSizeLimitation" via
> customization progress. Does anyone know the plan for the section? I didn't
> join the discussion before.

It looks like that we have had some conclusion via https://bugzilla.mozilla.org/show_bug.cgi?id=840061#c17.

But I feel strange that we define a limitation via customization. Once people change their sim-card and migrate to different carrier. Is the size limitation still meaningful and working for other carrier? 

If it is possible, I would like to suggest getting the size limitation via sim-card dynamically. It might need platform support.

Or we could give a default value if we cannot get any limitation in settings key. I think it would be better to have a default limitation with value 300(300kB). The specific number is referenced from wiki.(http://en.wikipedia.org/wiki/Multimedia_Messaging_Service#Challenges) Does it make sense? 

If I'm wrong, please feel free to correct me.

ni Kev from previous discussion. Thank you.

Comment 7

[Kev Needham [:kev]]

It might need platform support, but it would also require operator support (e.g. having SIM values as a known pref, and trumping app defaults if and only if it's different). I think it's a decent idea, but the requirement around the limit was that it could be set as part of the image customization, not pulled from SIM, and we should probably consult our operator and OEM partners and determine whether or not this is something they set in the SIM, and what parameter it would be, and go from there. 

I'm not crazy about a 300kb default without research. Generally this value is higher than 300 (e.g. 512kb-1024kb), and I'd want to set it to something that is typical and ensure our OEMs are aware that it's something they need to check to ensure there is no unintended consequences.

Comment 8

[[e-mail], [e-mail]]

According to previous discussion with platform dev, we have no way to get the size limitation from SIM-card or ril. For the section, Gene could be able to explain it.

I propose to give a default value 300 for the settings key. Then, we need to check the value from customization during launching SMS app in the first time. If our OEMs have given the threshold, we use and save it in SMS DB. Does it make sense?

Comment 9

[Julien Wajsberg [:julienw]]

(In reply to Ian Liu [:ianliu] from comment #8)
> According to previous discussion with platform dev, we have no way to get
> the size limitation from SIM-card or ril. For the section, Gene could be
> able to explain it.
> 
> I propose to give a default value 300 for the settings key.

I'd rather have bytes instead of kilobytes.

> Then, we need to
> check the value from customization during launching SMS app in the first
> time. If our OEMs have given the threshold, we use and save it in SMS DB.

I don't get why we need to save it in the SMS DB ?

Comment 10

[[e-mail], [e-mail]]

(In reply to Julien Wajsberg [:julienw] from comment #9)
> (In reply to Ian Liu [:ianliu] from comment #8)
> > According to previous discussion with platform dev, we have no way to get
> > the size limitation from SIM-card or ril. For the section, Gene could be
> > able to explain it.
> > 
> > I propose to give a default value 300 for the settings key.
> 
> I'd rather have bytes instead of kilobytes.
Agree, we should use bytes for the basic unit.
> 
> > Then, we need to
> > check the value from customization during launching SMS app in the first
> > time. If our OEMs have given the threshold, we use and save it in SMS DB.
> 
> I don't get why we need to save it in the SMS DB ?
Looks like we don't need to do so, since we always get the value via settings key.
I misunderstand that customized the data for SMS app only. It's part of settings DB key.

Comment 11

[[e-mail], [e-mail]]

Since we have a meeting at the work week in Taipei, we saperate the issue to aim comment 6. 

a) Define a default size limitation with 307200 bytes(300kilobytes) in settings key.
b) Get size limitation according to APN information.(Bug 886757)
c) OEMs are still able to overwrite the size limitation via customization.(But it would be better define the size limitation in apn.json. Because the value could be locked via customization)(https://wiki.mozilla.org/B2G/MarketCustomizations)

Comment 12

[[e-mail], [e-mail]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10622

Pointer to Github pull-request

Comment 13

[[e-mail], [e-mail]]

Comment on attachment 767561 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10622

* Define a default size limitation with 307200 bytes(300kilobytes) in settings key.
* The patch and Bug 873758(https://github.com/mozilla-b2g/gaia/pull/9854/files#L3R24) should be reviewed together. We should allow units unified in bytes.

Hi Corey,
Could you please help to review the pr? Thank you.

Comment 14

[Corey Frang [:gnarf]]

Comment on attachment 767561 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10622

Ian - could you please add the change to remove the *1024 from the sms app in with this patch we didn't include it in bug 873758

Also - take a look at my patch for bug 886757 as well?

Please r? me again when updated! Thanks!

Comment 15

[[e-mail], [e-mail]]

Comment on attachment 767561 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10622

* Update the patch according to Corey's comment.
* Revise unit test for the modification in sms setting.

For bug 886757, It uses the same unit with bytes. I think it should work normally. Thanks for your reminder.

Comment 16

[Corey Frang [:gnarf]]

Comment on attachment 767561 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10622

r=me (test only change request on the pull)

Comment 17

[[e-mail], [e-mail]]

Thanks for Corey's reviewing effort. Since the pr is landed, we can close the issue now.

master:   147240e7948e8710520bb3777d8707bcfa898c35
v1-train: 477e57212d4338e87182d9a8be96bb5c59c0a792

Comment 18

[John Ford [:jhford] CET/CEST Berlin Time]

v1.1.0hd: 477e57212d4338e87182d9a8be96bb5c59c0a792

Comment 19

[isabelrios]

'File too large' and 'Maximun lenght..' warning messages are shown.

Verified with unagi device 06/28 build:
Gecko-db60841
Gaia-508cfc8

Comment 20

[sbogati]

Issue no longer repros. on the Leo,
Build ID: 20130730070228
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/1fe3339e3d96
Gaia: 6221737cb50d6e8435ac5d3fe3b7e2788bd8a37c
Platform Version: 18.1
It is showing maximum limit warning.