Closed Bug 881713 Opened 9 years ago Closed 9 years ago

Switch custom double-click to minimize on titlebar to use performClick: for drawInTitlebar

Categories

(Core :: Widget: Cocoa, defect)

24 Branch
All
macOS
defect
Not set
minor

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: jsbruner, Assigned: jsbruner)

Details

Attachments

(1 file, 1 obsolete file)

Bug 853105 fixed the ability to allow double-clicking to minimize a window when drawInTitlebar is enabled and active on a window. It uses custom event handling in the widget code, however this could be handled better.

We now just send a minimize message, but that does "press" the minimize button like double-clicking to minimize does in other apps. To do this, we can easily switch to performClick:.
Does *not "press" the minimize button I mean.
Attached patch Patch. (obsolete) — Splinter Review
Makes the change. Stephen, you have a few minutes to review this?
Attachment #761020 - Flags: review?(smichaud)
Comment on attachment 761020 [details] [diff] [review]
Patch.

Looks good to me, with the following exception:

But "self.window" should be [self window].  'window' is a method of NSView, not a property.
Attachment #761020 - Flags: review?(smichaud) → review+
Attached patch Patch.Splinter Review
Attachment #761020 - Attachment is obsolete: true
Attachment #761064 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/4e0f0d13afd3
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.