881717 - Deal with err case in MakeAPI callback

Status: RESOLVED FIXED

(Webmaker Graveyard :: webmaker.org, defect)

Description

[David Humphrey (:humph)]

We have code in webmaker.org that is using the MakeAPI, but assuming that no error is returned.  This results in us trying to access a .length property of a null object (data), which in turn crashes the server.

The problem is in https://github.com/mozilla/webmaker.org/blob/master/lib/makeapi-webmaker.js#L7

We should be doing 2 things there.

1) check on what the value of err is, and if non-null, deal with it here (i.e., early callback vs. processing data).

2) check that data is non-null before we try to access any properties on it.  It *should* be an array; but if it isn't, let's not crash.

Comment 1

[Matthew Schranz [:mjschranz]]

Attachment: https://github.com/mozilla/webmaker.org/pull/106

Comment 2

[David Humphrey (:humph)]

Comment on attachment 760920 [details] [review]
https://github.com/mozilla/webmaker.org/pull/106

One switch to the data-null case, looks good with that.

Thanks for patching so quickly.  Let's get this landed.

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/e09818502e430a092af6d45488f017bbb1298b4b
Fix Bug 881717 - Handle error conditions from MakeAPI