881767 - Add required features to version resource

Status: RESOLVED FIXED

(Marketplace Graveyard :: API, defect, P2)

Description

[Rob Hudson [:robhudson]]

Update the app resource to take an optional list of required features for PUT and POST. Also include the list of required features on GET.

See also bug 881765 for the list of features.

Comment 1

[Chuck Harmston [:chuck]]

As features are tied to versions, this should technically be tied to the VersionResource, which is related to and included in the app resource:

http://firefox-marketplace-api.readthedocs.org/en/latest/topics/apps.html#get--api-v1-apps-app-%28int-id%29|%28string-slug%29-

Comment 2

[Chuck Harmston [:chuck]]

Part 1 of this landed: a list of required features is included in GET requests for apps.

https://github.com/mozilla/zamboni/commit/e3083b3ff3f8c00da0aa751d4c11c734d0b7249b

Docs: http://firefox-marketplace-api.readthedocs.org/en/latest/topics/apps.html

(NB: RTD's rebuild queue is pretty high right now, may take a while for the docs to rebuild)

Comment 3

[Chuck Harmston [:chuck]]

Currently blocked on https://github.com/tomchristie/django-rest-framework/issues/940, a solution for which is required so we can prevent non-app-owners from updating versions.

Comment 4

[Andy McKay]

Can't you just override the method and do the check manually in there as a workaround?

Comment 5

[Chuck Harmston [:chuck]]

Yeah, working on that as we speak. Very much a hack though, hoping to work with the DRF authors on a better solution for that tomorrow .

Comment 6

[Chuck Harmston [:chuck]]

Landed: https://github.com/mozilla/zamboni/commit/63c490b3dd309c0f2ad296cde4caa41fc6fd1541

Comment 7

[Chuck Harmston [:chuck]]

Docs: http://firefox-marketplace-api.readthedocs.org/en/latest/topics/apps.html#versions