Add required features to version resource

RESOLVED FIXED in 2013-07-11

Status

Marketplace
API
P2
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: robhudson, Assigned: chuck)

Tracking

2013-07-11
x86
Mac OS X
Points:
---

Details

(Whiteboard: [buchets] p=3)

(Reporter)

Description

5 years ago
Update the app resource to take an optional list of required features for PUT and POST. Also include the list of required features on GET.

See also bug 881765 for the list of features.
(Assignee)

Updated

5 years ago
Assignee: nobody → charmston
Blocks: 858314
Whiteboard: [buchets] p=1
(Assignee)

Updated

5 years ago
Target Milestone: --- → 2013-06-13
(Assignee)

Updated

5 years ago
Priority: -- → P2
(Assignee)

Comment 1

5 years ago
As features are tied to versions, this should technically be tied to the VersionResource, which is related to and included in the app resource:

http://firefox-marketplace-api.readthedocs.org/en/latest/topics/apps.html#get--api-v1-apps-app-%28int-id%29|%28string-slug%29-
Summary: Add required features to app resource → Add required features to version resource
(Assignee)

Comment 2

5 years ago
Part 1 of this landed: a list of required features is included in GET requests for apps.

https://github.com/mozilla/zamboni/commit/e3083b3ff3f8c00da0aa751d4c11c734d0b7249b

Docs: http://firefox-marketplace-api.readthedocs.org/en/latest/topics/apps.html

(NB: RTD's rebuild queue is pretty high right now, may take a while for the docs to rebuild)
Target Milestone: 2013-06-13 → 2013-06-20
Target Milestone: 2013-06-20 → 2013-06-27
(Assignee)

Comment 3

5 years ago
Currently blocked on https://github.com/tomchristie/django-rest-framework/issues/940, a solution for which is required so we can prevent non-app-owners from updating versions.

Comment 4

5 years ago
Can't you just override the method and do the check manually in there as a workaround?
(Assignee)

Comment 5

5 years ago
Yeah, working on that as we speak. Very much a hack though, hoping to work with the DRF authors on a better solution for that tomorrow .
Target Milestone: 2013-06-27 → 2013-07-04
Target Milestone: 2013-07-04 → 2013-07-11
(Assignee)

Comment 6

5 years ago
Landed: https://github.com/mozilla/zamboni/commit/63c490b3dd309c0f2ad296cde4caa41fc6fd1541
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [buchets] p=1 → [buchets] p=3
You need to log in before you can comment on or make changes to this bug.