Closed Bug 881802 Opened 8 years ago Closed 8 years ago

Editing Bookmark should be handled by a custom Dialog class

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 26

People

(Reporter: sriram, Assigned: sriram)

References

Details

(Whiteboard: fixed-fig)

Attachments

(1 file)

Editing bookmark should be factored out and be handled in a custom Dialog class.
Blocks: 878136
Depends on: 872388
Reading around, wasn't this done in bug 872388 patch 3/5? Or are you looking for something else here for the project about:home ... (dup?)
Attached patch PatchSplinter Review
Reduce. Reuse. Recyle.
Attachment #773429 - Flags: review?(wjohnston)
Comment on attachment 773429 [details] [diff] [review]
Patch

Review of attachment 773429 [details] [diff] [review]:
-----------------------------------------------------------------

Nice. Can you rename this bug to something like your commit message?
Attachment #773429 - Flags: review?(wjohnston) → review+
Assignee: nobody → sriram
Whiteboard: fixed-fig
https://hg.mozilla.org/mozilla-central/rev/276d77c4e049
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.