Closed
Bug 881816
Opened 13 years ago
Closed 13 years ago
Safely handle no results returned from MakeAPI
Categories
(Webmaker Graveyard :: webmaker.org, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mjschranz, Assigned: mjschranz)
Details
Attachments
(1 file)
We have been getting server crashes from not having this handled in the code. This can't make it to production.
|
Assignee | |
Comment 1•13 years ago
|
||
Should be an immediate R+
Attachment #761068 -
Flags: review?(jon)
|
|
Assignee | |
Comment 2•13 years ago
|
||
Comment on attachment 761068 [details] [review]
https://github.com/mozilla/webmaker.org/pull/109
Relieving Jon a bit.
Attachment #761068 -
Flags: review?(jon) → review?(david.humphrey)
|
||
Comment 3•13 years ago
|
||
Comment on attachment 761068 [details] [review]
https://github.com/mozilla/webmaker.org/pull/109
Drop the Ross stuff from this, and have it be a generic "Can't find this make" thing instead. R+ with that stuff removed.
Attachment #761068 -
Flags: review?(david.humphrey) → review-
|
||
Comment 4•13 years ago
|
||
Commit pushed to master at https://github.com/mozilla/webmaker.org
https://github.com/mozilla/webmaker.org/commit/e78be34650f3c0f2ac395dc5343b446a96b963c4
Fix Bug 881816 - Add additional error handling for when no results are returned on searches
|
|
||
Updated•13 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 5•13 years ago
|
||
That stuff was removed. Fun police :(
|
||
Updated•12 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•