[Cost Control] Mindgap component should compare dates in local time

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: salva, Assigned: salva)

Tracking

unspecified
x86_64
Linux
Dependency tree / graph

Firefox Tracking Flags

(blocking-b2g:leo+, b2g18 fixed, b2g-v1.1hd fixed)

Details

Attachments

(1 attachment)

When bug 877607 is solved, it causes a pseudo-regression related with bug 846402. It is a similar case but this time the error is happening in time zones GMT + XX.

See:
https://bugzilla.mozilla.org/show_bug.cgi?id=846402#c27

Now take in count, this assertion...
"Date B, is always the present day at 00:00 UTC."

...was, actually, the back-end bug 877607.
Created attachment 761125 [details]
Once the backend is fixed (bug 877607) and only time-zone-aware dates are returned, mindgap.js must compare local dates.
Attachment #761125 - Flags: review?(francisco.jordano)
Comment on attachment 761125 [details]
Once the backend is fixed (bug 877607) and only time-zone-aware dates are returned, mindgap.js must compare local dates.

Tried on the phone, working smoothly :)

Thanks Salva!
Attachment #761125 - Flags: review?(francisco.jordano) → review+

Comment 3

5 years ago
Bug-877607 is dependent on this bug.so changing it to leo+.
blocking-b2g: leo? → leo+
Master: 5eb19071334a4f71c23410363e0fdaee8a1fd5b3
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Uplifted 5eb19071334a4f71c23410363e0fdaee8a1fd5b3 to:
v1-train: 3816e74676e7705f0a9cd84857151e6b433f5485
status-b2g18: --- → fixed
1.1hd: 3816e74676e7705f0a9cd84857151e6b433f5485
status-b2g-v1.1hd: --- → fixed
You need to log in before you can comment on or make changes to this bug.