881946 - update graphite2 library to release 1.2.3

Status: RESOLVED FIXED

(Core :: Graphics: Text, defect)

Description

[Jonathan Kew [:jfkthame]]

Attachment: patch, update gfx/graphite2 to the 1.2.3 release

See upstream release announcement:

"Not much in the changelog but there is a key bug fix for good fonts with interesting cmap subtable lengths.

. fix byte swapping when testing cmap subtable lengths
. work around armel compilation problems with conditional operators
. fix pseudoglyph support for advance and bbox"

Comment 1

[John Daggett (:jtd)]

Does that calculation in Sparse.h make sense to you?

Comment 2

[Jonathan Kew [:jfkthame]]

I discussed this with Martin, and confirmed the change being made here is correct - it's just removing a multiplication by sizeof(mapped_type) as that will be done internally by the grzeroalloc<mapped_type> function anyway. So the old code was doing an excessive (clownshoes) allocation.

There -is- actually a (pre-existing) logic error in the expression, where it uses sizeof(mapped_type)/2 it should really be using sizeof(mapped_type)-1, but as mapped_type is uint16, the result is the same and nothing untoward will follow. :)

They'll fix this upstream, although unless/until the "sparse" class is genericized to accept a template argument for mapped_type instead of hardcoding it as uint16, it's not important for the generated code - both subexpressions simply evaluate to "1" at compile time.

Comment 3

[Jonathan Kew [:jfkthame]]

Attachment: update graphite2 library to release 1.2.3

Martin checked in the cleanup for the Sparse.h calculation to the graphite repo, so I've updated the patch here to include that. (As already noted, it makes no difference to the actual code, as the constant expression still evaluates to the same thing.)

Comment 4

[John Daggett (:jtd)]

Comment on attachment 762570 [details] [diff] [review]
update graphite2 library to release 1.2.3

Good, thanks.

Comment 5

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dbd84e331bbb

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/dbd84e331bbb