882053 - [Audio] Sound mode of indicator change when changeing volumne in youtube site

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect, P1)

Description

[Leo]

1. Title : Sound mode of indicator change when changeing volumne in youtube site
2. Precondition : 
3. Tester's Action : 
 1) Go to m.youtube.com in Web Browser and start playing a video
 2) While playing a video change volume to min and next to medium level, observe the system icon bar on the top of the screen.
4. Detailed Symptom : The vibrate only mode is on after changing volume level to min when playing YT video and doesn't change when changing volume to medium level 
5. Expected : Should not change the sound mode of indicator.
6. Reproducibility: Y
   - Frequency Rate : 100%
7.Gaia Master/v1-train : Reproduced
8. Version Info
Mozilla build ID: 20130526070207
Gaia Revision : 4d10e1297b859cacc174c0a54af61a7678d7c32d
Gecko Revision : 52341e43539a0e8b9aa77a9128cc3871439b8aa6

It's related with Bug 866036

Comment 1

[Jason Smith [:jsmith]]

I'm a bit confused here about the bug. Are you saying that we're adjusting the wrong volume indicator when playing a video? In other words - we should be adjusting the audio channel for media sound, not the audio channel for dialer sound, right?

Comment 2

[Leo]

Attachment: video

Comment 3

[hyuna.cho]

(In reply to Jason Smith [:jsmith] from comment #1)
> I'm a bit confused here about the bug. Are you saying that we're adjusting
> the wrong volume indicator when playing a video? In other words - we should
> be adjusting the audio channel for media sound, not the audio channel for
> dialer sound, right?

Regarding of Bug 866036, volume control should be:
1. if there is an active audio channel, the volume buttons should adjust that.
2. if there is a visible app, the volume buttons should adjust the content/normal audio channel.
3. otherwise (homescreen/lockscreen) the volume buttons adjust the ringer/notification audio channel.

Playing video in youtube page is case 1. So when adjust side vol key, audio channel should be changed. But now ringer/notification audio channel is also changed. You can find that in indicator icon.

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Looks like my bug ;)

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

It's a bug in multi-channel silent mode. Patch coming.

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/10380

Fix wrong trigger to enter silent mode.

Comment 7

[(inactive after 6/18) Alive Kuo [:alive]]

v1-train
https://github.com/mozilla-b2g/gaia/commit/649321f91bc2bc401e3b568ee9a84c0cfbbf1906

master
https://github.com/mozilla-b2g/gaia/commit/1a063208cf5e1d01101046ea31c4ff6e14317ab4

Comment 8

[John Ford [:jhford] CET/CEST Berlin Time]

1.1hd: 649321f91bc2bc401e3b568ee9a84c0cfbbf1906