882107 - Camera activities are broken

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Dale Harvey (:daleharvey)]

2 parallel patches landed seperately which caused extra calls to restartPreview as it was removed

Comment 1

[Dale Harvey (:daleharvey)]

Attachment: Pointer to GH

Comment 2

[Julien Wajsberg [:julienw]]

Comment on attachment 761381 [details]
Pointer to GH

r=me

thanks for the quick fix !

Comment 3

[Dale Harvey (:daleharvey)]

Merged in: https://github.com/mozilla-b2g/gaia/commit/d6d6fb4e5147d0a0b62d67e5e898e2bacbf86771

Comment 4

[Dale Harvey (:daleharvey)]

This is a follow up to https://bugzilla.mozilla.org/show_bug.cgi?id=870726 which is due to be uplifted

Comment 5

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 d6d6fb4e5147d0a0b62d67e5e898e2bacbf86771
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 6

[Dale Harvey (:daleharvey)]

Clearing my needinfo and adding Jim, as this needs to uplifted to follow https://bugzilla.mozilla.org/show_bug.cgi?id=870726

Comment 7

[Jim Porter (:squib)]

Uplifted to v1-train: https://github.com/mozilla-b2g/gaia/commit/f2d6ed54a236e6e3b94f0abad9f0dacb8a1cc7b3

I think I did this right. If not, let me know!

Comment 8

[Dale Harvey (:daleharvey)]

Clearing needinfo (was meant to earlier)

Comment 9

[John Ford [:jhford] CET/CEST Berlin Time]

1.1hd: f2d6ed54a236e6e3b94f0abad9f0dacb8a1cc7b3

Comment 10

[:CSchmoeckel]

No MozTrap Test Case created as Camera activities are tested in the [Camera] Test Suite.

Comment 11

[Jason Smith [:jsmith]]

(In reply to :CSchmoeckel from comment #10)
> No MozTrap Test Case created as Camera activities are tested in the [Camera]
> Test Suite.

That doesn't make sense to me. If there's already coverage here, link the appropriate test case here.

Comment 12

[:CSchmoeckel]

Bug failed Camera Suite Test Case# 1844 - [Camera] Launching the Camera App
From UCID [camera-001] - As a user I want to tap the camera button so that I can quickly and easily take a photo.

Comment 13

[Jason Smith [:jsmith]]

(In reply to :CSchmoeckel from comment #12)
> Bug failed Camera Suite Test Case# 1844 - [Camera] Launching the Camera App
> From UCID [camera-001] - As a user I want to tap the camera button so that I
> can quickly and easily take a photo.

This isn't answering the question I posed in comment 11. I want to see an exact test case that demonstrates reproducing the bug in MozTrap. This is in relation to web activities with the camera app, not just launching the camera app.

Comment 14

[Jason Smith [:jsmith]]

https://moztrap.mozilla.org/manage/cases/?pagenumber=1&pagesize=20&sortfield=created_on&sortdirection=desc&filter-id=7766 is the test case you wanted to find here.

Comment 15

[Sarah Parsons]

Verified fixed on Leo Build ID: 20130717070237

Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/582e3a7018b0
Gaia: c506c50adaaebcf729ac3c27887ba2931ab79040
Platform Version: 18.1
RIL Version: 01.01.00.019.158