88211 - Installer does not save proxy hostname in all-proxy.js

Status: RESOLVED WONTFIX

(SeaMonkey :: Installer, defect)

Description

[benc]

This has been going on for some time, and may have been caused by fixes applied
to all-proxy.js...

STEPS:
Successfully install via proxy using NS6.1beta1 for Win32.

Expected results:
a correct set of all-proxy.js entries would overlay three values under the
current implementation:

1- proxy hostname (network.proxy.ftp or network.proxy.http)
2- proxy port
3- proxy mode (1 = manual)

Observed results:
---begin file
pref("network.proxy.ftp_port", 8080);
pref("network.proxy.type", 1);
---end file

TECHNICAL ANALYSIS:
Manual proxy entries in preferences are ignored if the port==0 or if the
hostname is empty, so the net effect is to force all profiles run under this
installation to go to manual mode without having a usable proxy.

This can cause migrated or pre-existing profiles with old, unused manual proxy
information to be unexpectedly activated. Since the hostname entries are usually
invalid in this situation, it causes the browser to go deaf to the network in
most cases.

Comment 1

[basic]

this belongs in profile migration

Comment 2

[Daniel Veditz [:dveditz]]

No, it's installer. The thrust of this RFE is that if you've had to give proxy 
settings to the installer in order to download the .xpi packages, the 
installer should be smart enough to make sure Mozilla is set up correctly for 
you.

Comment 3

[Sean Su]

over to Curt.

Comment 4

[Grace Bush]

taking all proxy related bugs

Comment 5

[Grace Bush]

adding Ben to proxy bugs as requested

Comment 6

[Syd Logan]

david, how hard would this be to fix for buffy?

Comment 7

[dprice (gone)]

Let me see if I understand the problem correctly.
We want to make certain that all-proxy.js contains the settings that were given
to the native installer if it used a proxy server to download the xpi's. 

I'm fairly certain that the native installer doesn't do any setting of
preferences itself.  So we'll have to hold on to the proxy information until all
of the xpis have been installed (not hard), then look for all-proxy.js in all of
the places that file could be(see below), and update it manually(not hard).  

and we'd have to be certain that the preferences are not stomped on when the
initial launch happens.

below - If all-proxy.js only lives in the install directory then this should not
be hard.  But if there's a copy of the file in each profile, then we're a little
hosed because we don't know which ones to change.  A user may be on a laptop
with one profile for work and a proxy and one profile for home without a proxy.
 To make things more exciting, I don't think the native installers know how to
find the profile directories.

Comment 8

[benc]

It goes into:

<MOZILLABIN>/defaults/prefs/

Which is read by every profile before loading the profile specific files
(prefs.js and user.js(?)).

If you can't fix it, can you just turn it off?

I should mention this recently bit me again, causing a proxy test I was running
to fail inexplicably. Browser has  no proxy error handling, so I was confused,
scratcing my head for about 30 minutes.

Comment 9

[dprice (gone)]

Oh I get it now.  It isn't that we are not setting these preferences, it is that
we are setting them incorrectly.  Yeah we should be able to make certain that we
aren't putting out the wrong data, and it shouldn't be that hard to get into
buffy.  

Comment 10

[benc]

That's the topic of this bug. You can search on "all-proxy" in the summary to
see the other bugs.

Comment 11

[Syd Logan]

A comment

Comment 12

[Syd Logan]

minusing for buffy

Comment 13

[benc]

Syd: let me know if you still want this bug...

Comment 14

[benc]

If I hack that bug, then it will either work or fix bug 84732. Either way, I'll
be happy.

Comment 15

[benc]

Realized they aren't depends...

So, poking around and comparing checkin dates vs. bug reports (and realizing
that I never actually pasted in the text of a 3-line file, making this whole
process much more painful...)

I think this is a problem w/:
1.24	ssu%netscape.com	2001-05-11 01:56	 	fixing bug 73870 - Proxy saves http
proxy information as ftp preferences. r=dveditz, sr=mscott. affects only windows
platforms/builds

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/xpinstall/wizard/windows/setup&command=DIFF_FRAMESET&file=ifuncns.c&rev2=1.24&rev1=1.23

The first time this was reported broken was verifying the fix to this checkin.
The only difference I can see is the use of wsprintf vs. lstrcat.

At first, I thought it was:

 if(*diAdvancedSettings.szProxyServer != '\0') was failing, (hence bug 242690),
but that logic was in the original feature, so it is going into that branch, but
failing to write to the file for some reason.

Comment 16

[benc]

There is also a new UI problem.

Without at hostname, the proxy selector (control-click on offline-online icon),
shows "manual" as grey but selected, and "none" as available, but not selected.

If you select "none", then, as expected, you cannot select back to "manual".

Comment 17

[Matthias Versen [:Matti]]

Seamonkey and Firefox are using a new NSIS based installer. resolving this old bug, please reopen if you still get this with the new installer