882175 - Cell Broadcast setting is confusing

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Dale Harvey (:daleharvey)]

This feature got merged a little soon, current implementation is confusing as enabling the checkbox disables the feature, it should be the opposite

Comment 1

[Dale Harvey (:daleharvey)]

Attachment: Pointer to GH

Comment 2

[Dale Harvey (:daleharvey)]

The previous settings UI was merged prematurely and is extremely confusing (it shows the opposite of its intention), I think this should be uplifted with the rest of the CBS implementation

Comment 3

[Fabien Cazenave [:kaze]]

Comment on attachment 762957 [details]
Pointer to GH

r=me with nit addressed (see PR on github).
Sorry for merging the first patch too early. :-/

Comment 4

[Dale Harvey (:daleharvey)]

np, merged in: https://github.com/mozilla-b2g/gaia/commit/5ad48f6c2ac80027e88e8d0c469686946e34a9cd

Comment 5

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 5ad48f6c2ac80027e88e8d0c469686946e34a9cd
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 6

[Dale Harvey (:daleharvey)]

Resolved conflicts and merged into v1-train: https://github.com/mozilla-b2g/gaia/commit/c411b04a85b0975077842b3cfb6f1ada9a355b7c

Comment 7

[John Ford [:jhford] CET/CEST Berlin Time]

Marking branch resolution per comment 6

Comment 8

[John Ford [:jhford] CET/CEST Berlin Time]

1.1hd: c411b04a85b0975077842b3cfb6f1ada9a355b7c

Comment 9

[Angela Hubenya]

Can you please provide steps on how to test this feature?

Comment 11

[sarsenyev]

Verified on Leo device this bug is fixed, enabling the check-box enables the future

Environmental  Variables:
Build ID: 20130723070209
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/68fb0a2e0114
Gaia: ffe25bfdf0e71c820ca710cb61fb8306564a8f4e
Platform Version: 18.1
RIL Version: 01.01.00.019.138

Comment 12

[sarsenyev]

Please, ignore Comment 11 , the bug was verified incorrectly, based on "default settings", the "Cell broadcast" service is not available in our area
The issues still needs to be verified

Comment 13

[Darren]

Issue looks like it will be covered by test cases:
https://moztrap.mozilla.org/manage/cases/?filter-id=9378
https://moztrap.mozilla.org/manage/cases/?filter-id=9377