Closed Bug 882337 Opened 7 years ago Closed 7 years ago
Typo in "asterisk
In Wrong Section2" in browser/devtools/appcacheutils .properties
Bug 881057 have introduced typo in "asteriskInWrongSection2" string: asteriskInWrongSection2=Asterisk (*) incorrectly used in the %1$S section at line %2$S. If a line in the NETWORK section contains only a single asterisk character, then any URI not listed in the manifest will be treated as if the URI was listed in the NETWORK section. Otherwice such URIs will be treated as unavailable. Other uses of the * character are prohibited. s/Otherwice/Otherwise
Just to be clear, no need to change the entity name for this kind of fixes ;-)
I must have read over that at least 20 times but just never saw it ... well spotted.
Attachment #761946 - Flags: review?(mratcliffe)
Attachment #761946 - Flags: review?(mratcliffe) → review?(jwalker)
7 years ago
Attachment #761946 - Flags: review?(jwalker) → review+
Assignee: nobody → mratcliffe
Status: NEW → ASSIGNED
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
(In reply to Michael Ratcliffe [:miker] [:mratcliffe] from comment #4) > https://hg.mozilla.org/integration/fx-team/rev/09fd019331d3 Wouldn't it be easier to just localize these strings in tests?
It is a regex match so we can't really do that ... it would be good to find some solution though. I guess we could use a getRegexFromStringName() method. Bug 885806 logged.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 24
No longer blocks: 909681
6 years ago
No longer blocks: 885806
You need to log in before you can comment on or make changes to this bug.