882337 - Typo in "asteriskInWrongSection2" in browser/devtools/appcacheutils.properties

Status: RESOLVED FIXED

(DevTools Graveyard :: Graphic Commandline and Toolbar, defect)

Description

[Alexander L. Slovesnik]

Bug 881057 have introduced typo in "asteriskInWrongSection2" string:

asteriskInWrongSection2=Asterisk (*) incorrectly used in the %1$S section at line %2$S. If a line in the NETWORK section contains only a single asterisk character, then any URI not listed in the manifest will be treated as if the URI was listed in the NETWORK section. Otherwice such URIs will be treated as unavailable. Other uses of the * character are prohibited.

s/Otherwice/Otherwise

Comment 1

[Francesco Lodolo [:flod]]

Just to be clear, no need to change the entity name for this kind of fixes ;-)

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Patch

I must have read over that at least 20 times but just never saw it ... well spotted.

Comment 3

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/42b501546ca7

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

https://hg.mozilla.org/integration/fx-team/rev/09fd019331d3

Comment 5

[Victor Porof [:vporof][:vp]]

(In reply to Michael Ratcliffe [:miker] [:mratcliffe] from comment #4)
> https://hg.mozilla.org/integration/fx-team/rev/09fd019331d3

Wouldn't it be easier to just localize these strings in tests?

Comment 6

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

It is a regex match so we can't really do that ... it would be good to find some solution though.

I guess we could use a getRegexFromStringName() method. Bug 885806 logged.

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/42b501546ca7
https://hg.mozilla.org/mozilla-central/rev/09fd019331d3