Closed Bug 882369 Opened 11 years ago Closed 11 years ago

[SMS][MMS] Regression. contactList => contact-list for search results and group view

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::SMS
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:leo+, b2g18 fixed, b2g-v1.1hd fixed)

Status:
RESOLVED FIXED
Project Flags:
blocking-b2g leo+
Tracking Flags:
Tracking Status
b2g18 --- fixed
b2g-v1.1hd --- fixed

People

(Reporter: rwaldron, Assigned: rwaldron)

Details

(Keywords: regression)

Attachments

(1 file)

Fix for 882369
46 bytes, text/x-github-pull-request
borjasalguero
: review+
Details | Review 
The group view and search results are both contacts lists and must share this style. A renaming issue happened in they diverged.
requesting leo?
blocking-b2g: --- → leo?
Attached file Fix for 882369 — 

        Attachment #761589 -
        Flags: review?(fbsc)

    
    

    
  
Taking a look!

    
    

    
  
Please re-nominate with a user impact. How divergent are their styles?
blocking-b2g: leo? → -

    
    

    
  
Alex, I'm sorry if this wasn't clear: it's broken as in the styles are not being applied at all. 

Please leo+
blocking-b2g: - → leo?

    
    

    
  
Comment on attachment 761589 [details] [review]
Fix for 882369


Only a small comment. Thanks! R+.
https://github.com/mozilla-b2g/gaia/pull/10349#issuecomment-19448074

        Attachment #761589 -
        Flags: review?(fbsc) → review+

    
    

    
  
Landed https://github.com/mozilla-b2g/gaia/commit/3dee169168113a8b166ef2700ad0671d9022abfb
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
blocking-b2g: leo? → leo+
Keywords: regression

    
    

    
  
Uplifted 3dee169168113a8b166ef2700ad0671d9022abfb to:
v1-train: 15a244b62e1757283a1775077da6689c81d31017

          status-b2g18:
          --- → fixed

    
    

    
  
1.1hd: 15a244b62e1757283a1775077da6689c81d31017

          status-b2g-v1.1hd:
          --- → fixed

    
    

    
  
Can you please provide steps to verify this fix - as we can perform blackbox testing from the UI?
Attachment mime type: text/plain → text/x-github-pull-request

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: