882377 - Addon menuitems aren't remembered with don't keep activities set

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Wesley Johnston (:wesj)]

We're loosing our array of menu items whenever the main activity disappears. We should store it in a static variable so that it can live forever.

Comment 1

[Mark Capella [:capella]]

Fyi, I tried this real quick ... if you set |don't keep activities|, then

Start FF
Wait for Addons to load
Hit back to Exit out
Start FF (again)

not only did my addons dissapear but my Top Sites tiles won't load. It looks like it goes through a cycle of something like the below...
...
=== Hit back to Exit out ===
AboutHome.onDestroyView()
TopSitesView.onDestroy()
AboutHome.onDetach()
=== Start FF (again) ===
AboutHome.onAttach()
AboutHome.onCreate()
BrowserApp.onCreate()
...

Comment 2

[Mark Capella [:capella]]

So two issues, the original bug with addons, and TopSites getting lost during fast stop / starts ...

The latter looks like http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/widget/TopSitesView.java#206 is silently failing, maybe if the view is not attached to a window when the post is done ...?

Comment 4

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.