moz.build: variables that are a substring not playing nicely together

NEW
Unassigned

Status

()

Core
Build Config
5 years ago
5 years ago

People

(Reporter: joey, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
Patches to be attached.

Add support for two variables 'GARBAGE=' and 'GARBAGE_DIRS='.  The backend unit test fails because GARBAGE_DIRS has been appended to the GARBAGE variable.

Rename 'GARBAGE' to 'GARBAGE_1' and the unit test will pass.

Variable/value collection may need to be bounded to prevent including stray values.



TEST-UNEXPECTED-FAIL | /media/_Q/mozilla/bugs/882354/python/mozbuild/mozbuild/test/backend/test_recursivemake.py | line 202, test_variable_passthru: Lists differ: ['GARBAGE += bar.f.gbg', 'GARB... != [u'GARBAGE += bar.f.gbg', u'GA...

First list contains 2 additional elements.
First extra element 2:
GARBAGE_DIRS += bar.d.gbg

+ [u'GARBAGE += bar.f.gbg', u'GARBAGE += foo.f.gbg']
- ['GARBAGE += bar.f.gbg',
-  'GARBAGE += foo.f.gbg',
-  'GARBAGE_DIRS += bar.d.gbg',
-  'GARBAGE_DIRS += foo.d.gbg']
TEST-PASS | /media/_Q/mozilla/bugs/882354/python/mozbuild/mozbuild/test/backend/test_recursivemake.py | test_xpcshell_manifests
gmake: *** [run-/media/_Q/mozilla/bugs/882354/python/mozbuild/mozbuild/test/backend/test_recursivemake.py] Error 1
gmake: Leaving directory `/media/_Q/mozilla/bugs/882354/obj-x86_64-unknown-linux-gnu/python'
(Reporter)

Comment 1

5 years ago
Created attachment 761635 [details]
failing unit test
(Reporter)

Comment 2

5 years ago
Created attachment 761636 [details]
Unit test using 'GARBAGE_1'  variable
You need to log in before you can comment on or make changes to this bug.